Repository navigation
fix(expo): ask for an audio library only when neither expo-audio nor expo-av is installed - #3954
Merged
Conversation
…expo-av is installed `stream-chat-expo` logged "install the expo-av package" whenever expo-av was missing, even with expo-audio installed, which playback and recording use first. The log now runs once, when neither package is installed, and names expo-audio, since Expo has deprecated expo-av.
Contributor
SDK Size
|
oliverlaz
approved these changes
Nov 9, 2026
Contributor
|
🎉 This PR is included in version 10.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://linear.app/stream/issue/REACT-1538
Stacked on #3953.
🎯 Goal
Stop
stream-chat-expofrom logging "install the expo-av package" in apps that haveexpo-audioinstalled. Audio works in those apps, so the log is wrong, and it points to a package Expo has deprecated.🛠 Implementation details
AudioVideo.tslogged wheneverrequire('expo-av')failed, without checking forexpo-audio.Audio.tsandSound.tsuseexpo-audiofirst and fall back toexpo-avonly when it's missing.AudioVideo.ts.Sound.tsalready loads both packages, so it now logs once, only when neither is installed, and namesexpo-audio, for playback and voice recording.The
expo-avfallback stays.stream-chat-expov10 supports Expo 53 and 54, whereexpo-avstill works, so an app that never moved toexpo-audiokeeps its audio without a log. The same log has been ondevelopsince v7, so this isn't a v10 regression.🎨 UI Changes
None.
🧪 Testing
Sound.test.ts, with the optional packages mocked. With onlyexpo-audioinstalled there's no log, with onlyexpo-avthere's no log, and with neither there's one log namingexpo-audio. Without the fix, the first and third cases fail.yarn test:typecheck,prettierandyarn lintpass.☑️ Checklist
developbranch