Repository navigation
fix(ReactionListClustered): show the total reaction count per design - #3961
Merged
Merged
Conversation
The count next to the clustered reactions now shows the total number of reactions on the message whenever it is greater than 1, instead of the number of reaction types beyond the first four.
Adds the total count label as a new key instead of renaming the existing one, so translation dictionaries that override it keep compiling.
Contributor
SDK Size
|
oliverlaz
approved these changes
Nov 10, 2026
Contributor
|
🎉 This PR is included in version 10.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://linear.app/stream/issue/RN-519
🎯 Goal
Design fix: the number next to the clustered reactions should be the total number of reactions on the message, shown whenever it is greater than 1. It was showing the number of reaction types beyond the first four, and only when there were more than four types.
🛠 Implementation details
ReactionListClusteredsums thecountof every reaction type and shows the badge when the total is above 1.message.reactionList.total.accessibilityLabelkey.🧪 Testing
ReactionListClustered.test.tsx: the total across types, a single type reacted twice, the accessibility label, and no badge for a single reaction.