You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Remove redundant .resx files when updated dotnet ships. #3905
PR #3904 required that some .resx files be added to the src/buildfromsource/ directory. When a new dotnet sdk is shipped that has changes #3577 and #3607, then the .resx files (and their accompanying .fs files) should be removed.
Does resolving this issue remove the need to manually copy any files at all across to src\buildfromsource\FSharp.Compiler.Private\ (as per DEVGUIDE.md)?
Activity
dsyme commentedon Dec 1, 2017
+100
cartermp commentedon Feb 14, 2018
@brettfo Does this still need to be open?
brettfo commentedon Feb 15, 2018
There are still some we need to keep around for the proto build and buildfromsource, so it should stay open a bit longer.
TD5 commentedon Oct 10, 2018
Does resolving this issue remove the need to manually copy any files at all across to
src\buildfromsource\FSharp.Compiler.Private\(as per DEVGUIDE.md)?brettfo commentedon Oct 10, 2018
Yes, once this is resolved that manual copy step will go away. It should be handled by my changes in #5842.
cartermp commentedon Jan 30, 2019
@brettfo Now that we have an updated SDK we build against, can these files be removed?
cartermp commentedon May 1, 2019
Closing this as we no longer have this directory in our source build.