Add FetchLicenseTest for basic test coverage #280

Signed-off-by: Thomas Druez <tdruez@nexb.com>

Author: tdruez

src/attributecode/model.py

@@ -1416,7 +1416,7 @@ def pre_process_and_fetch_license_dict(abouts, api_url, api_key):
         msg = u'Network problem. Please check your Internet connection. License generation is skipped.'
         errors.append(Error(ERROR, msg))
     for about in abouts:
-        # No need to go thru all the about objects for license extraction if we detected
+        # No need to go through all the about objects for license extraction if we detected
         # invalid '--api_key'
         auth_error = Error(ERROR, u"Authorization denied. Invalid '--api_key'. License generation is skipped.")
         if auth_error in errors:
@@ -1472,7 +1472,7 @@ def valid_api_url(api_url):
         request = Request(api_url)
         # This will always goes to exception as no key are provided.
         # The purpose of this code is to validate the provided api_url is correct
-        response = urlopen(request)
+        urlopen(request)
     except HTTPError as http_e:
         # The 403 error code is refer to "Authentication credentials were not provided.".
         # This is correct as no key are provided.

tests/test_api.py

@@ -20,39 +20,30 @@
 
 import unittest
 
-from mock import patch
+import mock
 
 from attributecode import api
 from attributecode import ERROR
 from attributecode import Error
-
-
-class FakeResponse(object):
-    response_content = None
-
-    def __init__(self, response_content):
-        self.response_content = response_content
-
-    def read(self):
-        return self.response_content
+from testing_utils import FakeResponse
 
 
 class ApiTest(unittest.TestCase):
-    @patch.object(api, 'request_license_data')
-    def test_api_get_license_details_from_api(self, mock_data):
+    @mock.patch.object(api, 'request_license_data')
+    def test_api_get_license_details_from_api(self, request_license_data):
         license_data = {
             'name': 'Apache License 2.0',
             'full_text': 'Apache License Version 2.0 ...',
             'key': 'apache-2.0',
         }
         errors = []
-        mock_data.return_value = license_data, errors
+        request_license_data.return_value = license_data, errors
 
         expected = ('Apache License 2.0', 'apache-2.0', 'Apache License Version 2.0 ...', [])
         result = api.get_license_details_from_api('url', 'api_key', 'license_key')
         assert expected == result
 
-    @patch.object(api, 'urlopen')
+    @mock.patch.object(api, 'urlopen')
     def test_api_request_license_data(self, mock_data):
         response_content = (
             b'{"count":1,"results":[{"name":"Apache 2.0","key":"apache-2.0","text":"Text"}]}'

tests/test_model.py

@@ -25,11 +25,7 @@
 import unittest
 from unittest.case import expectedFailure
 
-from testing_utils import extract_test_loc
-from testing_utils import get_temp_file
-from testing_utils import get_test_loc
-from testing_utils import get_test_lines
-from testing_utils import get_unicode_content
+import mock
 
 import attributecode
 from attributecode import CRITICAL
@@ -41,6 +37,11 @@
 from attributecode import util
 from attributecode.util import add_unc
 from attributecode.util import load_csv
+from testing_utils import extract_test_loc
+from testing_utils import get_temp_file
+from testing_utils import get_test_loc
+from testing_utils import get_test_lines
+from testing_utils import get_unicode_content
 
 
 def check_csv(expected, result):
@@ -1313,3 +1314,25 @@ def test_by_name(self):
                                 ('eclipse', [d]),
                                 ])
         assert expected == results
+
+
+class FetchLicenseTest(unittest.TestCase):
+    @mock.patch.object(model, 'urlopen')
+    def test_valid_api_url(self, mock_data):
+        mock_data.return_value = ''
+        assert model.valid_api_url('non_valid_url') is False
+
+    @mock.patch('attributecode.util.have_network_connection')
+    @mock.patch('attributecode.model.valid_api_url')
+    def test_pre_process_and_fetch_license_dict(self, have_network_connection, valid_api_url):
+        have_network_connection.return_value = True
+
+        valid_api_url.return_value = False
+        error_msg = ('Network problem. Please check your Internet connection. '
+                     'License generation is skipped.')
+        expected = ({}, [Error(ERROR, error_msg)])
+        assert model.pre_process_and_fetch_license_dict([], '', '') == expected
+
+        valid_api_url.return_value = True
+        expected = ({}, [])
+        assert model.pre_process_and_fetch_license_dict([], '', '') == expected

tests/testing_utils.py

@@ -155,4 +155,14 @@ def extract_test_loc(path, extract_func=extract_zip):
     else:
         target_dir = get_temp_dir()
     extract_func(archive, target_dir)
-    return target_dir
+    return target_dir
+
+
+class FakeResponse(object):
+    response_content = None
+
+    def __init__(self, response_content):
+        self.response_content = response_content
+
+    def read(self):
+        return self.response_content