Handle removing resources without parents

Author: Mirochill

src/commoncode/resource.py

@@ -906,8 +906,9 @@ def remove_resource(self, resource):
         parent = resource.parent(self)
         if TRACE:
             logger_debug("    parent", parent)
-        parent.children_names.remove(resource.name)
-        parent.save(self)
+        if parent:
+            parent.children_names.remove(resource.name)
+            parent.save(self)
 
         # remove resource proper
         self._remove_resource(resource)

tests/test_resource.py

@@ -101,6 +101,19 @@ def test_walk_skip_root_basic(self):
         ]
         assert [(r.name, r.is_file) for r in results] == expected
 
+    def test_remove_resource_without_parent(self):
+        test_codebase = self.get_test_loc("resource/codebase")
+        codebase = Codebase(test_codebase)
+        resource = codebase.get_resource("codebase/dir/that")
+        parent = resource.parent(codebase)
+
+        codebase.resources_by_path.pop(parent.path)
+
+        removed_paths = codebase.remove_resource(resource)
+
+        assert removed_paths == {resource.location}
+        assert resource.path not in codebase.resources_by_path
+
     def test_walk_filtered_with_filtered_root(self):
         test_codebase = self.get_test_loc("resource/codebase")
         codebase = Codebase(test_codebase)