Test is_file, is_dir, and walk on symlinks

Signed-off-by: Jono Yang <jyang@nexb.com>

Author: JonoYang

tests/commoncode/data/symlink/test

@@ -209,3 +209,25 @@ def test_get_file_count(self):
         for test_file, count in tests:
             result = filetype.get_file_count(os.path.join(test_dir, test_file))
             assert count == result
+
+
+def SymlinkTest(FileBasedTesting):
+    test_data_dir = os.path.join(os.path.dirname(__file__), 'data')
+
+    @skipIf(on_windows, 'os.symlink does not work on Windows')
+    def test_is_file(self):
+        test_file = self.get_test_loc('symlink/test', copy=True)
+        temp_dir = fileutils.get_temp_dir()
+        test_link = join(temp_dir, 'test-link')
+        os.symlink(test_file, test_link)
+        assert filetype.is_file(test_link, allow_symlinks=True)
+        assert not filetype.is_file(test_link, allow_symlinks=False)
+
+    @skipIf(on_windows, 'os.symlink does not work on Windows')
+    def test_is_dir(self):
+        test_dir = self.get_test_loc('symlink', copy=True)
+        temp_dir = fileutils.get_temp_dir()
+        test_link = join(temp_dir, 'test-dir-link')
+        os.symlink(test_dir, test_link)
+        assert filetype.is_dir(test_link, allow_symlinks=True)
+        assert not filetype.is_dir(test_link, allow_symlinks=False)

tests/commoncode/test_filetype.py

@@ -384,6 +384,20 @@ def test_os_walk_can_walk_non_utf8_path_from_unicode_path(self):
         _dirpath, _dirnames, filenames = result
         assert 18 == len(filenames)
 
+    @skipIf(on_windows, 'os.symlink does not work on Windows')
+    def test_walk_on_symlinks(self):
+        test_dir = self.get_test_loc('symlink', copy=True)
+        temp_dir = fileutils.get_temp_dir()
+        test_link = join(temp_dir, 'test-dir-link')
+        os.symlink(test_dir, test_link)
+        results = list(fileutils.walk(test_link, allow_symlinks=True))
+        assert len(results) == 1
+        top, dirs, files = results[0]
+        top = os.path.basename(top)
+        assert 'test-dir-link' == top
+        assert [] == dirs
+        assert ['test'] == files
+
 
 class TestFileUtilsIter(FileBasedTesting):
     test_data_dir = os.path.join(os.path.dirname(__file__), 'data')