Address review feedback

Signed-off-by: Ayan Sinha Mahapatra <asmahapatra@aboutcode.org>

Author: AyanSinhaMahapatra

Dockerfile

@@ -38,11 +38,11 @@ WORKDIR /scancode-toolkit
 COPY . /scancode-toolkit
 
 # Initial configuration using ./configure, scancode-reindex-licenses to build
-# the base license index and scancode-cache-package-patterns to build the 
+# the base license index and scancode-reindex-package-patterns to build the 
 # package patterns cache
 RUN ./configure \
  && ./venv/bin/scancode-reindex-licenses \
- && ./venv/bin/scancode-cache-package-patterns
+ && ./venv/bin/scancode-reindex-package-patterns
 
 # Add scancode to path
 ENV PATH=/scancode-toolkit:$PATH

docs/source/rst_snippets/basic_options.rst

@@ -33,10 +33,11 @@ documenting a program's options. For example:
 --system-package             Scan ``<input>`` for installed system package
                              databases.
 
--b, --binary-package         Scan <input> for package and dependency related
-                             data in binaries. Note that looking for packages
-                             in binaries makes package scan slower.
-                             Currently supported binaries: Go, Rust.
+--package-in-compiled        Scan compiled executable binaries such as ELF,
+                             WinpE and Mach-O files, looking for structured
+                             package and dependency metadata. Note that looking for
+                             packages in binaries makes package scan slower.
+                             Currently supported compiled binaries: Go, Rust.
 
 --package-only               Scan ``<input>`` for system and application
                              only for package metadata, without license/

etc/release/scancode-create-pypi-wheel.sh

@@ -19,7 +19,7 @@ set -e
 
 ./configure --dev
 venv/bin/scancode-reindex-licenses
-venv/bin/scancode-cache-package-patterns
+venv/bin/scancode-reindex-package-patterns
 
 python_tag=$( python -c "import platform;print(f\"cp{''.join(platform.python_version_tuple()[:2])}\")" )
 

etc/release/scancode-create-release-app-linux.sh

@@ -65,7 +65,7 @@ cp -r etc/thirdparty $release_dir/etc
 # Build the wheel
 ./configure --dev
 venv/bin/scancode-reindex-licenses
-venv/bin/scancode-cache-package-patterns
+venv/bin/scancode-reindex-package-patterns
 venv/bin/python setup.py --quiet bdist_wheel --python-tag cp$python_version
 
 cp -r \

etc/release/scancode-create-release-app-macos.sh

@@ -63,7 +63,7 @@ cp -r etc/thirdparty $release_dir/etc
 # Build the wheel
 ./configure --dev
 venv/bin/scancode-reindex-licenses
-venv/bin/scancode-cache-package-patterns
+venv/bin/scancode-reindex-package-patterns
 venv/bin/python setup.py --quiet bdist_wheel --python-tag cp$python_version
 
 cp -r \

etc/release/scancode-create-release-app-windows.sh

@@ -62,7 +62,7 @@ cp -r etc/thirdparty $release_dir/etc
 # Build the wheel
 ./configure --dev
 venv/bin/scancode-reindex-licenses
-venv/bin/scancode-cache-package-patterns
+venv/bin/scancode-reindex-package-patterns
 venv/bin/python setup.py --quiet bdist_wheel --python-tag cp$python_version
 
 cp -r \

setup-mini.cfg

@@ -157,7 +157,7 @@ packages =
 console_scripts =
     scancode = scancode.cli:scancode
     scancode-reindex-licenses = licensedcode.reindex:reindex_licenses
-    scancode-cache-package-patterns = packagedcode.cache:cache_package_patterns
+    scancode-reindex-package-patterns = packagedcode.cache:cache_package_patterns
     scancode-license-data = licensedcode.license_db:dump_scancode_license_data
     regen-package-docs = packagedcode.regen_package_docs:regen_package_docs
     add-required-phrases = licensedcode.required_phrases:add_required_phrases

setup.cfg

@@ -159,7 +159,7 @@ packages =
 console_scripts =
     scancode = scancode.cli:scancode
     scancode-reindex-licenses = licensedcode.reindex:reindex_licenses
-    scancode-cache-package-patterns = packagedcode.cache:cache_package_patterns
+    scancode-reindex-package-patterns = packagedcode.cache:cache_package_patterns
     scancode-license-data = licensedcode.license_db:dump_scancode_license_data
     regen-package-docs = packagedcode.regen_package_docs:regen_package_docs
     add-required-phrases = licensedcode.required_phrases:add_required_phrases

src/licensedcode/cache.py

@@ -34,7 +34,6 @@
 LICENSE_INDEX_DIR = 'license_index'
 LICENSE_INDEX_FILENAME = 'index_cache'
 LICENSE_LOCKFILE_NAME = 'scancode_license_index_lockfile'
-LICENSE_CHECKSUM_FILE = 'scancode_license_index_tree_checksums'
 
 
 class LicenseCache:

src/packagedcode/__init__.py

@@ -248,30 +248,30 @@
 
 
 # These handlers are special as they use filetype to
-# detect these binaries instead of datafile path patterns
+# detect these compiled binaries instead of datafile path patterns
 # as these are optionally installed, we can skip checking
 # for filetype if these are not available
-BINARY_PACKAGE_DATAFILE_HANDLERS = []
+PACKAGE_IN_COMPILED_DATAFILE_HANDLERS = []
 
 try:
     from go_inspector.binary import get_go_binary_handler
     handler = get_go_binary_handler()
-    BINARY_PACKAGE_DATAFILE_HANDLERS.append(handler)
+    PACKAGE_IN_COMPILED_DATAFILE_HANDLERS.append(handler)
 except ImportError:
     pass
 
 try:
     from rust_inspector.packages import get_rust_binary_handler
     handler = get_rust_binary_handler()
-    BINARY_PACKAGE_DATAFILE_HANDLERS.append(handler)
+    PACKAGE_IN_COMPILED_DATAFILE_HANDLERS.append(handler)
 except ImportError:
     pass
 
 ALL_DATAFILE_HANDLERS = (
     APPLICATION_PACKAGE_DATAFILE_HANDLERS + [
         p for p in SYSTEM_PACKAGE_DATAFILE_HANDLERS
         if p not in APPLICATION_PACKAGE_DATAFILE_HANDLERS
-    ] + BINARY_PACKAGE_DATAFILE_HANDLERS
+    ] + PACKAGE_IN_COMPILED_DATAFILE_HANDLERS
 )
 
 # registry of all handler classes keyed by datasource_id