Handle string is_private in npm package.json

Reference: #4631
Signed-off-by: Ayan Sinha Mahapatra <asmahapatra@aboutcode.org>

Author: AyanSinhaMahapatra

src/packagedcode/npm.py

@@ -532,7 +532,9 @@ def _parse(cls, json_data, package_only=False):
 
         namespace, name = split_scoped_package_name(name)
 
-        is_private = json_data.get('private') or False
+        is_private = False
+        if json_data.get('private'):
+            is_private = True
         if is_private:
             urls = {}
         else:

tests/packagedcode/data/npm/private/react-devtools-fusebox.package-expected.json

@@ -56,7 +56,7 @@
     "notice_text": null,
     "source_packages": [],
     "file_references": [],
-    "is_private": "true",
+    "is_private": true,
     "is_virtual": false,
     "extra_data": {},
     "dependencies": [

tests/packagedcode/test_npm.py

@@ -251,7 +251,7 @@ def test_parse_package_json_is_private(self):
         expected_loc = self.get_test_loc(
             'npm/private/react-devtools-fusebox.package-expected.json')
         packages = npm.NpmPackageJsonHandler.parse(test_file)
-        self.check_packages_data(packages, expected_loc, regen=True)
+        self.check_packages_data(packages, expected_loc, regen=REGEN_TEST_FIXTURES)
 
     def test_is_datafile_package_lock_json_v1(self):
         test_file = self.get_test_loc('npm/package-lock-v1/package-lock.json')