Skip to content

Commit faa5f3a

Browse files
Modify package classes to inherit PackageManifest mixin
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
1 parent 1a4bd31 commit faa5f3a

31 files changed

Lines changed: 62 additions & 58 deletions

src/packagedcode/__init__.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,15 +102,16 @@
102102
if len(PACKAGE_MANIFESTS_BY_TYPE) != len(PACKAGE_MANIFEST_TYPES):
103103
seen_types = {}
104104
for pmt in PACKAGE_MANIFEST_TYPES:
105-
assert pmt.default_type
106-
seen = seen_types.get(pmt.default_type)
105+
manifest = pmt()
106+
assert manifest.package_manifest_type
107+
seen = seen_types.get(manifest.package_manifest_type)
107108
if seen:
108109
msg = ('Invalid duplicated packagedcode.Package types: '
109110
'"{}:{}" and "{}:{}" have the same type.'
110-
.format(pmt.default_type, pmt.__name__, seen.default_type, seen.__name__,))
111+
.format(manifest.package_manifest_type, manifest.__name__, seen.package_manifest_type, seen.__name__,))
111112
raise Exception(msg)
112113
else:
113-
seen_types[pmt.default_type] = pmt
114+
seen_types[manifest.package_manifest_type] = manifest
114115

115116

116117
def get_package_class(scan_data, default=models.Package):

src/packagedcode/about.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
# TODO: Override get_package_resource so it returns the Resource that the ABOUT file is describing
3030

3131
@attr.s()
32-
class AboutPackage(models.Package):
32+
class AboutPackage(models.Package, models.PackageManifest):
3333
file_patterns = ('*.ABOUT',)
3434
default_type = 'about'
3535

src/packagedcode/alpine.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828

2929
@attr.s()
30-
class AlpinePackage(models.Package):
30+
class AlpinePackage(models.Package, models.PackageManifest):
3131
extensions = ('.apk', 'APKBUILD')
3232
default_type = 'alpine'
3333

src/packagedcode/bower.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131

3232
@attr.s()
33-
class BowerPackage(models.Package):
33+
class BowerPackage(models.Package, models.PackageManifest):
3434
file_patterns = ('bower.json', '.bower.json')
3535
default_type = 'bower'
3636

src/packagedcode/build.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939

4040
@attr.s()
41-
class BaseBuildManifestPackage(models.Package):
41+
class BaseBuildManifestPackage(models.Package, models.PackageManifest):
4242
file_patterns = tuple()
4343

4444
@classmethod

src/packagedcode/cargo.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434

3535

3636
@attr.s()
37-
class RustCargoCrate(models.Package):
37+
class RustCargoCrate(models.Package, models.PackageManifest):
3838
file_patterns = ('Cargo.toml', 'Cargo.lock')
3939
default_type = 'cargo'
4040
default_primary_language = 'Rust'

src/packagedcode/chef.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939

4040
@attr.s()
41-
class ChefPackage(models.Package):
41+
class ChefPackage(models.Package, models.PackageManifest):
4242
file_patterns = ('metadata.json', 'metadata.rb')
4343
filetypes = ('.tgz',)
4444
mimetypes = ('application/x-tar',)

src/packagedcode/cocoapods.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343

4444

4545
@attr.s()
46-
class CocoapodsPackage(models.Package):
46+
class CocoapodsPackage(models.Package, models.PackageManifest):
4747
metafiles = (
4848
'*.podspec',
4949
'*podfile.lock',

src/packagedcode/conda.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def logger_debug(*args):
4444

4545

4646
@attr.s()
47-
class CondaPackage(models.Package):
47+
class CondaPackage(models.Package, models.PackageManifest):
4848
file_patterns = ('meta.yaml', 'META.yml',)
4949
default_type = 'conda'
5050
default_web_baseurl = None

src/packagedcode/cran.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434

3535

3636
@attr.s()
37-
class CranPackage(models.Package):
37+
class CranPackage(models.Package, models.PackageManifest):
3838
file_patterns = ('DESCRIPTION',)
3939
default_type = 'cran'
4040
default_web_baseurl = 'https://cran.r-project.org/package='

0 commit comments

Comments
 (0)