Create tests for new CodebaseResource methods #447

    * Update walk test to also test for new parent and sibling related methods on CodebaseResource
    * Remove has_sibling method from CodebaseResource

Signed-off-by: Jono Yang <jyang@nexb.com>

Author: JonoYang

scanpipe/models.py

@@ -861,7 +861,7 @@ def error_count(self):
         """
         return self.projecterrors.count()
 
-    @property
+    @cached_property
     def has_single_resource(self):
         """
         Return True if we only have a single CodebaseResource associated to this
@@ -1640,15 +1640,6 @@ def parent(self, codebase=None):
         parent_path = self.parent_path()
         return parent_path and self.project.codebaseresources.get(path=parent_path)
 
-    def has_siblings(self, codebase=None):
-        """
-        Return True is this CodebaseResource has siblings.
-
-        `codebase` is not used in this context but required for compatibility
-        with the commoncode.resource.Codebase class API.
-        """
-        return self.has_parent() and self.parent(codebase).has_children()
-
     def siblings(self, codebase=None):
         """
         Return a sequence of sibling Resource objects for this Resource

scanpipe/pipes/__init__.py

@@ -113,8 +113,7 @@ def update_or_create_dependencies(project, dependency_data):
     """
     for_package_uid = dependency_data.get("for_package_uid")
     try:
-        dependency = DiscoveredDependency.objects.get(
-            project=project,
+        dependency = project.discovereddependencys.get(
             dependency_uid=dependency_data.get("dependency_uid"),
             for_package_uid=for_package_uid,
         )

scanpipe/tests/test_models.py

@@ -1200,6 +1200,33 @@ def test_scanpipe_codebase_resource_model_walk_method(self):
         ]
         self.assertEqual(expected_bottom_up_paths, bottom_up_paths)
 
+        # Test parent-related methods
+        asgiref_resource = self.project_asgiref.codebaseresources.get(
+            path="asgiref-3.3.0.whl-extract/asgiref/compatibility.py"
+        )
+        expected_parent_path = "asgiref-3.3.0.whl-extract/asgiref"
+        self.assertEqual(expected_parent_path, asgiref_resource.parent_path())
+        self.assertTrue(asgiref_resource.has_parent())
+        expected_parent = self.project_asgiref.codebaseresources.get(
+            path="asgiref-3.3.0.whl-extract/asgiref"
+        )
+        self.assertEqual(expected_parent, asgiref_resource.parent())
+
+        # Test sibling-related methods
+        expected_siblings = [
+            "asgiref-3.3.0.whl-extract/asgiref/__init__.py",
+            "asgiref-3.3.0.whl-extract/asgiref/compatibility.py",
+            "asgiref-3.3.0.whl-extract/asgiref/current_thread_executor.py",
+            "asgiref-3.3.0.whl-extract/asgiref/local.py",
+            "asgiref-3.3.0.whl-extract/asgiref/server.py",
+            "asgiref-3.3.0.whl-extract/asgiref/sync.py",
+            "asgiref-3.3.0.whl-extract/asgiref/testing.py",
+            "asgiref-3.3.0.whl-extract/asgiref/timeout.py",
+            "asgiref-3.3.0.whl-extract/asgiref/wsgi.py",
+        ]
+        asgiref_resource_siblings = [r.path for r in asgiref_resource.siblings()]
+        self.assertEqual(sorted(expected_siblings), sorted(asgiref_resource_siblings))
+
     @mock.patch("requests.post")
     def test_scanpipe_webhook_subscription_send_method(self, mock_post):
         webhook = self.project1.add_webhook_subscription("https://localhost")