Skip to content

Commit 69fc18a

Browse files
committed
Fix Formating and typo in test
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
1 parent 131b68e commit 69fc18a

3 files changed

Lines changed: 13 additions & 12 deletions

File tree

scanpipe/pipelines/analyze_symbols_reachability.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
#
2020
# ScanCode.io is a free software code scanning tool from nexB Inc. and others.
2121
# Visit https://github.com/aboutcode-org/scancode.io for support and download.
22+
2223
import json
2324
import os
2425
import shutil

scanpipe/pipes/reachability.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
#
2020
# ScanCode.io is a free software code scanning tool from nexB Inc. and others.
2121
# Visit https://github.com/aboutcode-org/scancode.io for support and download.
22-
#
22+
2323
import difflib
2424
import shutil
2525
import tempfile

scanpipe/tests/pipes/test_symbols_reachability.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ def test_end_to_end_symbol_reachability_pipeline(
135135
],
136136
"fixed_symbols": ["process_data"],
137137
"vulnerable_symbols": ["process_data"],
138-
"reachability_status": "YES",
138+
"reachability_status": ReachabilityStatus.REACHABLE.value,
139139
}
140140
]
141141

@@ -228,7 +228,7 @@ def test_generate_advisory_reachability_report(self):
228228

229229
expected_report = {
230230
"AVID-1": {
231-
"reachable": "YES",
231+
"reachable": ReachabilityStatus.REACHABLE.value,
232232
"details": [
233233
{
234234
"resource_path": "src/file2.py",
@@ -247,7 +247,7 @@ def test_generate_advisory_reachability_report(self):
247247
"vcs_url": "https://example.com",
248248
"commit_hash": "abc123",
249249
},
250-
"reachability_status": "YES",
250+
"reachability_status": ReachabilityStatus.REACHABLE.value,
251251
"evidence": [
252252
{
253253
"symbol_name": "vuln_sym1",
@@ -265,7 +265,7 @@ def test_generate_advisory_reachability_report(self):
265265
],
266266
},
267267
"AVID-2": {
268-
"reachable": "YES",
268+
"reachable": ReachabilityStatus.REACHABLE.value,
269269
"details": [
270270
{
271271
"resource_path": "src/file3.py",
@@ -284,7 +284,7 @@ def test_generate_advisory_reachability_report(self):
284284
"vcs_url": "https://example.com",
285285
"commit_hash": "abc123",
286286
},
287-
"reachability_status": "YES",
287+
"reachability_status": ReachabilityStatus.REACHABLE.value,
288288
"evidence": [
289289
{
290290
"symbol_name": "vuln_sym1",
@@ -435,7 +435,7 @@ def test_python_get_symbol_reachability_results(
435435
"serve_report",
436436
"serve_report.build_file_path",
437437
],
438-
"reachability_status": "YES",
438+
"reachability_status": ReachabilityStatus.REACHABLE.value,
439439
}
440440
]
441441

@@ -509,7 +509,7 @@ def test_java_get_symbol_reachability_results(
509509
"App.buildFilePath",
510510
"App.serveReport",
511511
],
512-
"reachability_status": "YES",
512+
"reachability_status": ReachabilityStatus.REACHABLE.value,
513513
}
514514
]
515515

@@ -632,19 +632,19 @@ def test_classify_reachability(self):
632632
self.assertEqual(classify_reachability(None), ReachabilityStatus.NOT_REACHABLE)
633633
self.assertEqual(classify_reachability({}), ReachabilityStatus.NOT_REACHABLE)
634634
self.assertEqual(
635-
classify_reachability({"symbol1": {}}), ReachabilityStatus.NOT_REACHABLE
635+
classify_reachability({"evidence": {}}), ReachabilityStatus.NOT_REACHABLE
636636
)
637637
self.assertEqual(
638-
classify_reachability({"symbol1": {"fingerprint": "hash123"}}),
638+
classify_reachability({"evidence": {"fingerprint": "hash123"}}),
639639
ReachabilityStatus.REACHABLE,
640640
)
641641

642642
self.assertEqual(
643-
classify_reachability({"symbol1": {"imported": True, "called": True}}),
643+
classify_reachability({"evidence": {"imported": True, "called": True}}),
644644
ReachabilityStatus.REACHABLE,
645645
)
646646
self.assertEqual(
647-
classify_reachability({"symbol1": {"imported": True, "called": False}}),
647+
classify_reachability({"evidence": {"imported": True, "called": False}}),
648648
ReachabilityStatus.UNKNOWN,
649649
)
650650
self.assertEqual(

0 commit comments

Comments
 (0)