Add test for get_purl_from_node_module

Signed-off-by: Keshav Priyadarshi <git@keshav.space>

Author: keshav-space

scanpipe/pipes/d2d.py

@@ -908,7 +908,7 @@ def _map_javascript_npm_lookup_resource(
     project,
 ):
     """Map unmatched ``node_modules`` files."""
-    purl = js.get_purl_from_node_module(to_directory)
+    purl = js.get_purl_from_node_module(to_directory.path)
     matched = to_resources.filter(path__startswith=to_directory.path)
     if not matched:
         return 0

scanpipe/pipes/js.py

@@ -210,7 +210,7 @@ def get_js_map_basename_and_extension(filename):
 
 def get_purl_from_node_module(node_module_directory):
     """Return PURL for given a `node_modules` package directory."""
-    path = Path(node_module_directory.path)
+    path = Path(node_module_directory)
     path_parts = path.parts
 
     npm_package = path_parts[-1]

scanpipe/tests/pipes/test_js.py

@@ -319,3 +319,20 @@ def test_scanpipe_pipes_js_get_basename_and_extension(self):
         for ext in js._js_extensions:
             basename, extension = js.get_js_map_basename_and_extension(f"file{ext}")
             self.assertEqual(("file", ext), (basename, extension))
+
+    def test_scanpipe_pipes_js_get_purl_from_node_module(self):
+        node_module_directory1 = "atls!template-util$codemirror@5.65.2/"
+        expected1 = "pkg:npm/codemirror@5.65.2"
+        result1 = str(js.get_purl_from_node_module(node_module_directory1))
+
+        node_module_directory2 = "@atls!sig-local$babel%2Fruntime@7.17.9/"
+        expected2 = "pkg:npm/%40babel/runtime@7.17.9"
+        result2 = str(js.get_purl_from_node_module(node_module_directory2))
+
+        node_module_directory3 = "codemirror@5.65.2/"
+        expected3 = "pkg:npm/codemirror@5.65.2"
+        result3 = str(js.get_purl_from_node_module(node_module_directory3))
+
+        self.assertEqual(expected1, result1)
+        self.assertEqual(expected2, result2)
+        self.assertEqual(expected3, result3)