Skip to content

Commit 8109819

Browse files
authored
Merge pull request #572 from nexB/564-improve-documentDescribes-spdx-sbom
564 improve document describes spdx sbom
2 parents caffcba + 9087fef commit 8109819

4 files changed

Lines changed: 15 additions & 3 deletions

File tree

CHANGELOG.rst

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,13 @@
11
Changelog
22
=========
33

4+
v33.0.0 (unreleased)
5+
--------------------
6+
7+
- Populate ``documentDescribes`` field with Package and Dependency SPDX IDs in
8+
SPDX BOM output.
9+
https://github.com/nexB/scancode.io/issues/564
10+
411
v32.0.0 (2022-11-29)
512
--------------------
613

scanpipe/spdx/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -578,7 +578,7 @@ def as_dict(self):
578578
"documentNamespace": self.namespace,
579579
"creationInfo": self.creation_info.as_dict(),
580580
"packages": [package.as_dict() for package in self.packages],
581-
"documentDescribes": [self.spdx_id],
581+
"documentDescribes": [package.spdx_id for package in self.packages],
582582
}
583583

584584
if self.files:

scanpipe/spdx/test_spdx.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ def setUp(self):
247247
"licenseComments": "license_comments",
248248
}
249249
],
250-
"documentDescribes": ["SPDXRef-DOCUMENT"],
250+
"documentDescribes": ["SPDXRef-package1"],
251251
"hasExtractedLicensingInfos": [
252252
{
253253
"licenseId": "LicenseRef-1",

scanpipe/tests/data/asgiref-3.3.0.spdx.json

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,12 @@
116116
}
117117
],
118118
"documentDescribes": [
119-
"SPDXRef-DOCUMENT"
119+
"SPDXRef-scancodeio-discoveredpackage-7f975593-4bdd-4217-8d04-3554d691f310",
120+
"SPDXRef-scancodeio-discoveredpackage-edf75850-316d-4a46-9ca1-bde1f4fc3aab",
121+
"SPDXRef-scancodeio-discovereddependency-pkg:pypi/pytest?uuid=6ef94d27-ae57-408e-baa4-e20e3dc1f1aa",
122+
"SPDXRef-scancodeio-discovereddependency-pkg:pypi/pytest?uuid=4b195723-fe04-47c9-8b65-c08c60423c18",
123+
"SPDXRef-scancodeio-discovereddependency-pkg:pypi/pytest-asyncio?uuid=87beebac-2c45-4adf-a700-a9a6ad1724e9",
124+
"SPDXRef-scancodeio-discovereddependency-pkg:pypi/pytest-asyncio?uuid=26af7b66-1034-4e21-9a2a-6dc1616a34ec"
120125
],
121126
"files": [],
122127
"relationships": [

0 commit comments

Comments
 (0)