Unable to use Express middleware due to request type incompatible #285

Activity

1. devonpmack commented on Jul 2, 2022

   

   devonpmack

   on Jul 2, 2022

   More actions

   I also can reproduce with the libraries compression and forcedomain. But it works as expected if you just cast to any.
2. NexZhu commented on Jul 2, 2022

   

   NexZhu

   on Jul 2, 2022

   ContributorAuthor

   More actions

   Casting to any didn't work for me with https://github.com/auth0/express-openid-connect
3. marcj commented on Jul 2, 2022

   

   marcj

   on Jul 2, 2022

   Owner

   More actions

   I think we have to adjust https://github.com/deepkit/deepkit-framework/blob/master/packages/http/src/model.ts#L179 in order to make it compatible with the request object interface required by those middlewares.
4. marcj commented on Jul 2, 2022

   

   marcj

   on Jul 2, 2022

   Owner

   More actions

   I wonder though why in the stack trace is express code node_modules/.pnpm/express@4.18.1/node_modules/express/lib/router/layer.js:95. Are you using express and Deepkit at the same time?
5. NexZhu commented on Jul 3, 2022

   

   NexZhu

   on Jul 3, 2022

   Last edited by NexZhu

   ContributorAuthor

   More actions

   No, I'm just using a type from express (needed by the express-openid-connect middleware, here's my code:

   import { http, HttpRequest, HttpResponse } from '@deepkit/http'
   import type { RequestHandler } from 'express'
   import { auth } from 'express-openid-connect'
   
   import { Config } from '~/config'
   
   @http.middleware()
   export class OidcMiddleware {
     private expressOpenid: RequestHandler
   
     constructor(protected config: Config['oidc']) {
       this.expressOpenid = auth(config)
     }
   
     execute(
       req: HttpRequest,
       res: HttpResponse,
       next: (err?: unknown) => void,
     ): void {
       // @ts-expect-error: req's param type is incompatible but correct
       // eslint-disable-next-line @typescript-eslint/no-unsafe-argument,@typescript-eslint/no-explicit-any
       this.expressOpenid(req as any, res, next)
     }
   }
6. NexZhu commented on Jul 3, 2022

   

   NexZhu

   on Jul 3, 2022

   ContributorAuthor

   More actions

   Casting the arguments to the exact types expected by the middleware still results in the same error:

   @http.middleware()
   export class OidcMiddleware {
     private expressOpenid: RequestHandler
   
     constructor(protected config: Config['oidc']) {
       this.expressOpenid = auth(config)
     }
   
     execute(
       req: HttpRequest,
       res: HttpResponse,
       next: (err?: unknown) => void,
     ): void {
       this.expressOpenid(
         req as unknown as Parameters<RequestHandler>[0],
         res as unknown as Parameters<RequestHandler>[1],
         next,
       )
     }
   }
7. NexZhu commented on Jul 3, 2022

   

   NexZhu

   on Jul 3, 2022

   Last edited by NexZhu

   ContributorAuthor

   More actions

   I also can reproduce with the libraries compression and forcedomain. But it works as expected if you just cast to any.

   @devonpmack Could you please share your code?
8. devonpmack commented on Jul 4, 2022

   

   devonpmack

   on Jul 4, 2022

   Last edited by devonpmack

   More actions

   Ah maybe it's because compression and forcedomain don't try to call req.get. My code was just complaining about a type error in the IDE, but it runs properly.

   middlewares: [
       httpMiddleware.for(compression() as any),
       httpMiddleware.for(
         forceDomain(domain(process.env.NODE_ENV as NodeEnv)) as any
       ),
     ],

   If I take out as any

   
9. NexZhu commented on Jul 5, 2022

   

   NexZhu

   on Jul 5, 2022

   ContributorAuthor

   More actions

   Yeah, seems to be different cases, my error happened in run time.
10. marcj

    added 2 commits that reference this issue on Jan 20, 2026

    feat(http): add Express-compatible get() and header() methods (#285)

    ...

    699dca1

    docs: update todo.md with #285 completion

    9d82b76
11. marcj

    added a commit that references this issue on Feb 8, 2026

    feat(http): add CORS support, Express compat, and 5 bug fixes

    ...

    e01f37f