Repository navigation
fix: log statement is for devDir not nodedir - #2840
Merged
Merged
Conversation
rvagg
approved these changes
May 10, 2023
rvagg
left a comment
Member
There was a problem hiding this comment.
yeah, you're right I think, good catch
Signed-off-by: David Sanders <dsanders11@ucsbalum.com>
Contributor
Author
|
@cclauss, this should be ready for merging, rebased on |
cclauss
approved these changes
Jun 6, 2023
cclauss
pushed a commit
to cclauss/node-gyp
that referenced
this pull request
Jun 13, 2023
Signed-off-by: David Sanders <dsanders11@ucsbalum.com>
lukekarrys
pushed a commit
that referenced
this pull request
Dec 2, 2024
Signed-off-by: David Sanders <dsanders11@ucsbalum.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change
Updating this log statement to be accurate.