Repository navigation
refactor(velox): drop the unused config pipeline metadata - #146
Merged
Merged
Conversation
Every step recorded flags in the context metadata, but nothing outside the tests ever read them. The build mixins step also lost a `toToml()` call whose result was discarded. Assisted-By: Claude Opus 5.5
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
ConfigContextno longer carries metadata: the*_appliedflags the Velox config steps wrote there were never read outside the tests.withMetadata()andaddMetadata()are removed.BuildMixinsProcessorloses atoToml()call whose result was discarded; docblocks ofBuildMixinsProcessorandBaseTemplateProcessornow describe what the steps actually do.velox.tomlis the same.Checklist