[luancurti]

Summary

Display spinner should respect display prop

Closes #117

Test Plan

Run this demo https://github.com/otaviogaiao/teste-datepicker and date picker with mode spinner and date picker with spinner should be displayed

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS	Implemented
Android	✅❌

Checklist

• I have tested this on a device and a simulator
• I added the documentation in README.md
• I mentioned this change in CHANGELOG.md
• I updated the typed files (TS and Flow)
• I added a sample use of the API in the example project (example/App.js)

[vonovak]

Let me please take a look at this before we merge, thanks!

[luancurti]

Let me please take a look at this before we merge, thanks!

Of Course!

[lochness42]

That's why I didn't merge it yet

[TreeMan360]

Any idea when this will be merged in?

[TreeMan360]

I thought this was going to make it into SDK 37 ;(

[vonovak]

@luancurti are you planning to look into this? Thanks :)

[luancurti]

@luancurti are you planning to look into this? Thanks :)

Yes, I'll make the suggested changes before the weekend

[luancurti]

Tested on Android Nougat 7.0 SDK 24

[TreeMan360]

This does not fix the problem for me once deployed as a standalone app (expo). I still get the 'default' clock when I select 'spinner'.

This happens with ALL our Android test devices.

[vonovak]

@TreeMan360 as you pointed out, this fix is not available in expo 37 (managed workflow), so I'm unsure how you're reproducing it. Please open a new issue and provide a runnable reproduction (follow the issue template), or alternatively, consider contributing a PR with a fix for your issue, thank you.

[TreeMan360]

@TreeMan360 as you pointed out, this fix is not available in expo 37 (managed workflow), so I'm unsure how you're reproducing it. Please open a new issue and provide a runnable reproduction (follow the issue template), or alternatively, consider contributing a PR with a fix for your issue, thank you.

I just referenced the new package and ignored the expo warning saying it may not be compatible. I assume from your response that this is not plausible (I would like to understand why?) so I guess I will either be forced to not use this package or wait until 38 (far from ideal).

[vonovak]

Expo sdk ships native code from one of the previous versions of this package (use expo install to find which one), so even if you manually install the latest version of this package you will not actually run the latest version.

But note that the bug which was fixed on this PR only exists in Android version 7, and it's not a bug that would prevent user from picking a date.

[TreeMan360]

Ok thanks for the explanation that makes sense. My problem is simply that once I make a standalone app the “spinner” display is not used. This is across multiple android versions, I always get the clock. It’s fine in development. So is this a separate issue?

[vonovak]

This sounds like a separate issue. But if it's fine in development but wrong in release build, that's pretty weird. You can try opening a new issue but please note we require runnable reproduction to consider the issue as valid - and that might not be easy in this case.
It might be best if you investigate this yourself because I think it'll take a while before maintenainers will have time to look into this.