Skip to content

Using @react-native-community/eslint-config - #3

Merged
Swaagie merged 2 commits into
react-native-datetimepicker:masterfrom
DanielSanudo:GX-16937
May 23, 2019
Merged

Using @react-native-community/eslint-config#3
Swaagie merged 2 commits into
react-native-datetimepicker:masterfrom
DanielSanudo:GX-16937

Conversation

@DanielSanudo

@DanielSanudo DanielSanudo commented May 23, 2019 •
edited by Swaagie
Loading

Copy link
Copy Markdown
Collaborator
  • Integrating @react-native-community/eslint-config@0.0.5
  • Included test folder for linting
  • Added posttest step for linting

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

Swaagie
Swaagie approved these changes May 23, 2019
View reviewed changes

@Swaagie Swaagie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, would be nice if we could just read the .prettierrc from react-native, but it is not bundled with the package.

@DanielSanudo DanielSanudo mentioned this pull request May 23, 2019
Merged
5 tasks
@Swaagie
Swaagie merged commit 8a70702 into react-native-datetimepicker:master May 23, 2019
@DanielSanudo
DanielSanudo deleted the GX-16937 branch May 24, 2019 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Swaagie Swaagie Swaagie approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DanielSanudo @Swaagie @dsanudovacas