[lochness42]

Summary

I've needed to allow to display CLEAR button along the default two buttons present on Android pickers. In order to do so, I've utilised DialogInterface.BUTTON_NEUTRAL to which I assign label from neutralButtonLabel property if present. If not, button is not rendered.
Presses of this button can be observed in onChange handler and returns neutralButtonPressed action type.
I've enabled this new button on both DatePickers and TimePickers to keep functional parity between them

Screenshot of date picker with added neutral button

Test Plan

What's required for testing (prerequisites)?

Run on Android and add your chosen neutralButtonLabel property on DateTimePicker component.

What are the steps to reproduce (after prerequisites)?

Open DateTimePicker and you should be able to see your new button with chosen label and it's presses can be obtained through onChange handler.

Compatibility

OS	Implemented
iOS	❌
Android	✅

Checklist

• I have tested this on a device and a simulator
• I added the documentation in README.md
• I mentioned this change in CHANGELOG.md
• I updated the typed files (TS and Flow)
• I added a sample use of the API in the example project (example/App.js)

[vonovak]

hi! thanks for your contribution, this is looking, good. Can you just rebase on top of master and resolve the comments? thanks!

[vonovak]

can you move this case above the default branch for readability? thanks

[vonovak]

instead of having this local variable that you assign later on, would it be possible to extract the logic of the ifs and switch statements into a separate function that just returns the TimePickerDialog instance?

[lochness42]

Absolutely, I've just mirrored existing code as I wanted to keep consistency of approach with existing codebase. https://github.com/react-native-community/react-native-datetimepicker/blob/bdcee75420bb796a94ef010f8c751378cd8b4e05/android/src/main/java/com/reactcommunity/rndatetimepicker/RNDatePickerDialogFragment.java#L55

[lochness42]

I've refactored both to have same approach

[vonovak]

please use #### which is a little more readable, the readme was just updated to that format, thank you.

[lochness42]

hi! thanks for your contribution, this is looking, good. Can you just rebase on top of master and resolve the comments? thanks!

Thank you very much for your review, I've updated code to reflect your comments.

[vonovak]

thanks! Would you be interested in becoming a maintainer?

[luancurti]

thanks! Would you be interested in becoming a maintainer?

@vonovak I have interest to help to maintain the module