Skip to content

Commit 62b993f

Browse files
committed
fix: IsNumberString accept isNumbericOptions as argument
BREAKING CHANGE: IsNumberString decorator arguments changed to @IsNumberString(ValidatorJS.IsNumericOptions, ValidationOptions). Closes #518, #463
1 parent 4eb1216 commit 62b993f

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎src/decorator/decorators.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -548,13 +548,13 @@ export function IsBooleanString(validationOptions?: ValidationOptions): Property
548548
/**
549549
* Checks if the string is a number.
550550
*/
551-
export function IsNumberString(validationOptions?: ValidationOptions, NumberOptions?: IsNumberOptions): PropertyDecorator {
551+
export function IsNumberString(options?: ValidatorJS.IsNumericOptions, validationOptions?: ValidationOptions): PropertyDecorator {
552552
return function (object: Object, propertyName: string) {
553553
const args: ValidationMetadataArgs = {
554554
type: ValidationTypes.IS_NUMBER_STRING,
555555
target: object.constructor,
556556
propertyName: propertyName,
557-
constraints: [NumberOptions],
557+
constraints: [options],
558558
validationOptions: validationOptions
559559
};
560560
getMetadataStorage().addValidationMetadata(new ValidationMetadata(args));

‎src/validation/Validator.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ export class Validator {
182182
case ValidationTypes.IS_BOOLEAN_STRING:
183183
return this.isBooleanString(value);
184184
case ValidationTypes.IS_NUMBER_STRING:
185-
return this.isNumberString(value);
185+
return this.isNumberString(value, metadata.constraints[0]);
186186

187187
/* string checkers */
188188
case ValidationTypes.CONTAINS:

0 commit comments

Comments
 (0)