Repository navigation
feat: new ValidatePromise decorator - resolve promise before validate - #369
Merged
Merged
Conversation
Contributor
Author
|
Node v12 CI tests failed while v10 tests passed. Looks like library internal error. |
Contributor
Author
|
Also looks like I forgot to increase version in |
Contributor
|
@queses could you please rebase? Tests should be fixed in latest commit. |
Contributor
Author
|
Yup, it's OK now |
ValidatePromise decorator - resolve promise before validate
Contributor
|
Thank you! :) |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new
@ValidatePromisedecorator to mark property as Promise that should to be resolved before validation.Tests for new decorator lays in
promise-validation.spec.ts.Example of use: