Repository navigation
fix(json): keep integers beyond isize exact - #661
Merged
Merged
Conversation
patrick-immometrica
temporarily deployed
to
MuslLinux
November 9, 2026 04:13 — with
GitHub Actions
Inactive
patrick-immometrica
temporarily deployed
to
MacOS
November 9, 2026 04:13 — with
GitHub Actions
Inactive
patrick-immometrica
temporarily deployed
to
MuslLinux
November 9, 2026 04:13 — with
GitHub Actions
Inactive
patrick-immometrica
temporarily deployed
to
Windows
November 9, 2026 04:13 — with
GitHub Actions
Inactive
patrick-immometrica
temporarily deployed
to
MacOS
November 9, 2026 04:13 — with
GitHub Actions
Inactive
patrick-immometrica
temporarily deployed
to
Windows
November 9, 2026 04:13 — with
GitHub Actions
Inactive
patrick-immometrica
temporarily deployed
to
MuslLinux
November 9, 2026 04:13 — with
GitHub Actions
Inactive
patrick-immometrica
temporarily deployed
to
MuslLinux
November 9, 2026 04:13 — with
GitHub Actions
Inactive
patrick-immometrica
temporarily deployed
to
Windows
November 9, 2026 04:13 — with
GitHub Actions
Inactive
patrick-immometrica
temporarily deployed
to
Windows
November 9, 2026 04:13 — with
GitHub Actions
Inactive
patrick-immometrica
temporarily deployed
to
Windows
November 9, 2026 04:13 — with
GitHub Actions
Inactive
patrick-immometrica
temporarily deployed
to
MacOS
November 9, 2026 04:13 — with
GitHub Actions
Inactive
patrick-immometrica
temporarily deployed
to
MacOS
November 9, 2026 04:13 — with
GitHub Actions
Inactive
patrick-immometrica
temporarily deployed
to
Windows
November 9, 2026 04:13 — with
GitHub Actions
Inactive
patrick-immometrica
temporarily deployed
to
MuslLinux
November 9, 2026 04:13 — with
GitHub Actions
Inactive
patrick-immometrica
temporarily deployed
to
MuslLinux
November 9, 2026 04:13 — with
GitHub Actions
Inactive
patrick-immometrica
temporarily deployed
to
MuslLinux
November 9, 2026 04:13 — with
GitHub Actions
Inactive
patrick-immometrica
temporarily deployed
to
MuslLinux
November 9, 2026 04:13 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stops from turning large integers into floats. Before the fix, integers were stored as Rust
isize, so any value outside that range, such as2**63, became anf64and lost precision. This happened both in JSON request and response bodies (src/client/body/json.rs) and in query parameters (src/client/param.rs). The fix uses an i64 variant plus a new u64 variant (UInt), so whole numbers from-(2**63)up to2**64 - 1now go out and come back exact. A new test sends{"a": 2**63, "b": -(2**63)}as JSON and2**64 - 1as a query value to a local server and checks the exact digits on the wire. The response test now expects 2**63 to decode as a Python int, no longer a float.