Repository navigation
perf(json): convert values by type and build response objects without a hash map - #664
Open
patrick-immometrica wants to merge 3 commits into
Open
patrick-immometrica wants to merge 3 commits into
patrick-immometrica wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python values in JSON bodies, query strings and form data are now converted by checking their type first (str, bool, int, float, None, dict, list/tuple), where before each variant was tried in turn until one worked. JSON objects in responses are stored as a plain list of key/value pairs instead of a hash map, and one buffer is shared while the whole response is parsed, which saves the per-object hashing and allocations before the result becomes a Python dict. A new test in tests/request_test.py sends every value type to a local server and checks the exact bytes, so the output stays the same.