Skip to content

update(mysql): Move provisioner to the executable-level CredentialUsage configuration - #293

Open
arunsathiya wants to merge 2 commits into
mainfrom
arun/mysql-default-provisioner-to-nil
Open

arunsathiya wants to merge 2 commits into
mainfrom
arun/mysql-default-provisioner-to-nil

Conversation

@arunsathiya

Copy link
Copy Markdown
Contributor

Overview

MySQL provisioner is moved to the executable-level CredentialUsage configuration, thus making it work only for mysql commands. MySQL Terraform provider supported, if any in the future, will use the DefaultProvisioner instead. For now, the default provisioner is set to nil.

Type of change

  • Created a new plugin
  • Improved an existing plugin
  • Fixed a bug in an existing plugin
  • Improved contributor utilities or experience

Related Issue(s)

How To Test

  • Clone this branch and run make mysql/build
  • Run op plugin init mysql and set up your MySQL secrets as a 1Password item.
  • Follow testing instructions as in the original MySQL work. Does the command still succeed?

Changelog

Move MySQL provisioner to the executable-level CredentialUsage configuration.

@arunsathiya arunsathiya added the waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member label Jun 15, 2023
@arunsathiya
arunsathiya requested review from AndyTitu and accraw June 15, 2023 04:12
@arunsathiya arunsathiya self-assigned this Jun 15, 2023
@arunsathiya

arunsathiya commented Jun 15, 2023

Copy link
Copy Markdown
Contributor Author

I spent a fair amount of time trying to set up a MySQL Terraform provider but none of the three I tried seemed to work. Two issues:

  • They seem to prompt for the username (despite there being a username field on the 1Password item),
  • If I enter the username manually and move forward, it seems to get stuck on the database creation stage.
image image

I am not sure why these are happening, but I attribute these to being not-fairly-regularly-maintained community providers. There was one maintained by Hashicorp but it seems to be archived now.

I can continue to take a closer look at these community-maintained providers and when one of these successfully works, and when the majority of the providers confirm to have the same environment variables, we can update the MySQL DefaultProvisioner. Until then, I propose/agree that we set it to nil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant