Repository navigation
fix(ci): Align Airflow E2E DAG parameter names with ml-auto-solutions - #4806
Merged
Merged
Conversation
RexBearIU
requested review from
bvandermoon,
darisoy,
gobbleturk,
huytransformer,
igorts-git,
khatwanimohit,
parambole,
richjames0,
shralex and
xibinliu
as code owners
August 10, 2026 08:44
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Update the Airflow REST API payload in run_e2e_tests.yml to pass 'commit_sha' and 'github_token' instead of 'maxtext_sha' and 'github_callback_token', matching the standardized DAG parameters defined in GoogleCloudPlatform/ml-auto-solutions.
RexBearIU
force-pushed
the
jackyf/fix-e2e-airflow-params
branch
from
August 10, 2026 08:45
0a78d1f to
9b8d4e0
Compare
SurbhiJainUSC
approved these changes
Aug 10, 2026
YixuanWang-99
approved these changes
Aug 10, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Airflow REST API request payload in
.github/workflows/run_e2e_tests.ymlto usecommit_shaandgithub_tokenparameter names instead ofmaxtext_shaandgithub_callback_token.Background & Motivation
In
GoogleCloudPlatform/ml-auto-solutions(commit310ce8d/ PR #1329), the DAG parameters formaxtext_e2e_testswere standardized to generic namescommit_shaandgithub_token. Because Airflow 2.10.x validates incomingconfparameters strictly against the DAG's definedparams, triggering the DAG from MaxText's nightly/release workflows resulted inHTTP 400 Bad Request: Invalid input for param commit_sha: No value passed and Param has no default value.Aligning the payload parameter keys in
run_e2e_tests.ymlresolves the HTTP 400 error and allows the E2E Airflow DAG to be triggered successfully.Tests
yamllint,codespell).dags/multipod/maxtext_e2e_tests.pyinGoogleCloudPlatform/ml-auto-solutions.Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.