You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
observer: forget partial write, and wrong messages from synapse_forget_rule and synapse_record_learning #212
Bugs from the QA and architect passes on PR #210 (#38). They are listed separately so they are not lost inside the owner decision on #211.
Partial write on forget.forgetLearning reads and checks every store first (fix(opencode): a refused forget changes no rule store; document mirrored project rules (#38) #210). But if the global write succeeds and the project write then fails, the call returns 0 while the global copy is already tombstoned (marked deleted). On Windows a rename can fail with EPERM or EBUSY when another process holds the file. Fix ideas: roll back the first write, or return a "partial" result the tool can report.
Wrong message on a refused forget.synapse_forget_rule says "No rule matched" when forgetLearning returned 0 because a store could not be read. It should say the stores could not be checked and nothing was changed.
False "recorded" message. If no store can be written (all unreadable or all writes fail), recordLearning still returns the entry, and synapse_record_learning says "Successfully recorded" though nothing was saved.
Activity
fix(opencode): malformed rule rows count as unreadable; record says w…
Alter-Igor commentedon Oct 17, 2026
Update from PR #210:
recordLearningnow returnssavedTo, andsynapse_record_learningsays "for this project only" or that nothing was saved.observer.ts(selectInjectedandlistLearnings) still accept any array. A[null]row makesisLivethrow there. They should usereadRuleStore's row check. This was already true before fix(opencode): a refused forget changes no rule store; document mirrored project rules (#38) #210.readRuleStoreshould also list "a row that is not a rule". The inline comment already says it.Items 1 and 2 are still open.
fix(opencode): a refused forget changes no rule store; document mirro…
fix(opencode): a failed forget's reply says when putting a store back…
fix(opencode): a failed forget puts stores back and says why; rule re…