Skip to content

Reject StreamingTranscriber.connect on early socket failure - #155

Closed
RitwijParmar wants to merge 1 commit into
AssemblyAI:mainfrom
RitwijParmar:codex/assemblyai-streaming-connect-rejects
Closed

RitwijParmar wants to merge 1 commit into
AssemblyAI:mainfrom
RitwijParmar:codex/assemblyai-streaming-connect-rejects

Conversation

@RitwijParmar

Copy link
Copy Markdown

What

  • Reject StreamingTranscriber.connect() if the socket errors before the Begin event.
  • Reject StreamingTranscriber.connect() if the socket closes before the Begin event.
  • Add unit coverage for both early-failure paths.

Why

Fixes #136. Today these pre-Begin failures only emit listeners, so await transcriber.connect() can remain pending indefinitely and callers cannot handle DNS/proxy/transport failures with try/catch or retry logic.

Verification

  • git diff --check
  • corepack pnpm@8.15.9 jest --config jest.unit.config.js tests/unit/streaming.test.ts --testTimeout 5000
  • corepack pnpm@8.15.9 lint:tsc

@RitwijParmar

Copy link
Copy Markdown
Author

Closing this PR because it has been inactive for several months and is no longer merge-ready. Thanks for the consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StreamingTranscriber.connect() hangs indefinitely on failure

1 participant