Skip to content

[CI Environment] [MAJOR/BREAKING] Authentication overhaul #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Marius Storhaug (MariusStorhaug) wants to merge 1 commit into from
Closed

[CI Environment] [MAJOR/BREAKING] Authentication overhaul #1606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/actions/templates/publishModule/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,9 @@ runs:
- name: Azure Login
uses: Azure/login@v1
with:
creds: ${{ env.AZURE_CREDENTIALS }}
client-id: ${{ env.ARM_CLIENT_ID }}
tenant-id: ${{ env.ARM_TENANT_ID }}
subscription-id: ${{ env.ARM_SUBSCRIPTION_ID }}
enable-AzPSSession: true

- name: 'Publish module to template specs'
Expand Down
4 changes: 3 additions & 1 deletion .github/actions/templates/validateModuleDeployment/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,9 @@ runs:
- name: Azure Login
uses: Azure/login@v1
with:
creds: ${{ env.AZURE_CREDENTIALS }}
client-id: ${{ env.ARM_CLIENT_ID }}
tenant-id: ${{ env.ARM_TENANT_ID }}
subscription-id: ${{ env.ARM_SUBSCRIPTION_ID }}
enable-AzPSSession: true

# [Token replacement] task(s)
Expand Down
4 changes: 3 additions & 1 deletion .github/actions/templates/validateModulePester/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ runs:
- name: 'Azure Login'
uses: Azure/login@v1
with:
creds: ${{ env.AZURE_CREDENTIALS }}
client-id: ${{ env.ARM_CLIENT_ID }}
tenant-id: ${{ env.ARM_TENANT_ID }}
subscription-id: ${{ env.ARM_SUBSCRIPTION_ID }}
enable-AzPSSession: true

# [Module Pester Test] task(s)
Expand Down
12 changes: 11 additions & 1 deletion .github/workflows/ms.aad.domainservices.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,17 @@ on:
- 'utilities/pipelines/**'
- '!utilities/pipelines/dependencies/**'

permissions:
id-token: write # OIDC
contents: read # OIDC
checks: write # enricomi/publish-unit-test-result-action
pull-requests: write # enricomi/publish-unit-test-result-action

env:
variablesPath: 'global.variables.yml'
modulePath: 'arm/Microsoft.AAD/DomainServices'
workflowPath: '.github/workflows/ms.aad.domainservices.yml'
AZURE_CREDENTIALS: ${{ secrets.AZURE_CREDENTIALS }}
ARM_CLIENT_ID: ${{ secrets.ARM_CLIENT_ID }}
ARM_SUBSCRIPTION_ID: '${{ secrets.ARM_SUBSCRIPTION_ID }}'
ARM_MGMTGROUP_ID: '${{ secrets.ARM_MGMTGROUP_ID }}'
ARM_TENANT_ID: '${{ secrets.ARM_TENANT_ID }}'
Expand All @@ -42,6 +48,7 @@ jobs:
job_initialize_pipeline:
runs-on: ubuntu-20.04
name: 'Initialize pipeline'
environment: 'Engineering'
steps:
- name: 'Checkout'
uses: actions/checkout@v2
Expand All @@ -67,6 +74,7 @@ jobs:
job_module_pester_validation:
runs-on: ubuntu-20.04
name: 'Static validation'
environment: 'Engineering'
steps:
- name: 'Checkout'
uses: actions/checkout@v2
Expand All @@ -83,6 +91,7 @@ jobs:
job_module_deploy_validation:
runs-on: ubuntu-20.04
name: 'Deployment validation'
environment: 'Engineering'
needs:
- job_initialize_pipeline
- job_module_pester_validation
Expand Down Expand Up @@ -115,6 +124,7 @@ jobs:
##################
job_publish_module:
name: 'Publishing'
environment: 'Engineering'
if: github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master' || github.event.inputs.prerelease == 'true'
runs-on: ubuntu-20.04
needs:
Expand Down
12 changes: 11 additions & 1 deletion .github/workflows/ms.analysisservices.servers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,17 @@ on:
- 'utilities/pipelines/**'
- '!utilities/pipelines/dependencies/**'

permissions:
id-token: write # OIDC
contents: read # OIDC
checks: write # enricomi/publish-unit-test-result-action
pull-requests: write # enricomi/publish-unit-test-result-action

env:
variablesPath: 'global.variables.yml'
modulePath: 'arm/Microsoft.AnalysisServices/servers'
workflowPath: '.github/workflows/ms.analysisservices.servers.yml'
AZURE_CREDENTIALS: ${{ secrets.AZURE_CREDENTIALS }}
ARM_CLIENT_ID: ${{ secrets.ARM_CLIENT_ID }}
ARM_SUBSCRIPTION_ID: '${{ secrets.ARM_SUBSCRIPTION_ID }}'
ARM_MGMTGROUP_ID: '${{ secrets.ARM_MGMTGROUP_ID }}'
ARM_TENANT_ID: '${{ secrets.ARM_TENANT_ID }}'
Expand All @@ -42,6 +48,7 @@ jobs:
job_initialize_pipeline:
runs-on: ubuntu-20.04
name: 'Initialize pipeline'
environment: 'Engineering'
steps:
- name: 'Checkout'
uses: actions/checkout@v2
Expand All @@ -67,6 +74,7 @@ jobs:
job_module_pester_validation:
runs-on: ubuntu-20.04
name: 'Static validation'
environment: 'Engineering'
steps:
- name: 'Checkout'
uses: actions/checkout@v2
Expand All @@ -83,6 +91,7 @@ jobs:
job_module_deploy_validation:
runs-on: ubuntu-20.04
name: 'Deployment validation'
environment: 'Engineering'
needs:
- job_initialize_pipeline
- job_module_pester_validation
Expand Down Expand Up @@ -115,6 +124,7 @@ jobs:
##################
job_publish_module:
name: 'Publishing'
environment: 'Engineering'
if: github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master' || github.event.inputs.prerelease == 'true'
runs-on: ubuntu-20.04
needs:
Expand Down
12 changes: 11 additions & 1 deletion .github/workflows/ms.apimanagement.service.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,17 @@ on:
- 'utilities/pipelines/**'
- '!utilities/pipelines/dependencies/**'

permissions:
id-token: write # OIDC
contents: read # OIDC
checks: write # enricomi/publish-unit-test-result-action
pull-requests: write # enricomi/publish-unit-test-result-action

env:
variablesPath: 'global.variables.yml'
modulePath: 'arm/Microsoft.ApiManagement/service'
workflowPath: '.github/workflows/ms.apimanagement.service.yml'
AZURE_CREDENTIALS: ${{ secrets.AZURE_CREDENTIALS }}
ARM_CLIENT_ID: ${{ secrets.ARM_CLIENT_ID }}
ARM_SUBSCRIPTION_ID: '${{ secrets.ARM_SUBSCRIPTION_ID }}'
ARM_MGMTGROUP_ID: '${{ secrets.ARM_MGMTGROUP_ID }}'
ARM_TENANT_ID: '${{ secrets.ARM_TENANT_ID }}'
Expand All @@ -42,6 +48,7 @@ jobs:
job_initialize_pipeline:
runs-on: ubuntu-20.04
name: 'Initialize pipeline'
environment: 'Engineering'
steps:
- name: 'Checkout'
uses: actions/checkout@v2
Expand All @@ -67,6 +74,7 @@ jobs:
job_module_pester_validation:
runs-on: ubuntu-20.04
name: 'Static validation'
environment: 'Engineering'
steps:
- name: 'Checkout'
uses: actions/checkout@v2
Expand All @@ -83,6 +91,7 @@ jobs:
job_module_deploy_validation:
runs-on: ubuntu-20.04
name: 'Deployment validation'
environment: 'Engineering'
needs:
- job_initialize_pipeline
- job_module_pester_validation
Expand Down Expand Up @@ -115,6 +124,7 @@ jobs:
##################
job_publish_module:
name: 'Publishing'
environment: 'Engineering'
if: github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master' || github.event.inputs.prerelease == 'true'
runs-on: ubuntu-20.04
needs:
Expand Down
12 changes: 11 additions & 1 deletion .github/workflows/ms.appconfiguration.configurationstores.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,17 @@ on:
- 'utilities/pipelines/**'
- '!utilities/pipelines/dependencies/**'

permissions:
id-token: write # OIDC
contents: read # OIDC
checks: write # enricomi/publish-unit-test-result-action
pull-requests: write # enricomi/publish-unit-test-result-action

env:
variablesPath: 'global.variables.yml'
modulePath: 'arm/Microsoft.AppConfiguration/configurationStores'
workflowPath: '.github/workflows/ms.appconfiguration.configurationstores.yml'
AZURE_CREDENTIALS: ${{ secrets.AZURE_CREDENTIALS }}
ARM_CLIENT_ID: ${{ secrets.ARM_CLIENT_ID }}
ARM_SUBSCRIPTION_ID: '${{ secrets.ARM_SUBSCRIPTION_ID }}'
ARM_MGMTGROUP_ID: '${{ secrets.ARM_MGMTGROUP_ID }}'
ARM_TENANT_ID: '${{ secrets.ARM_TENANT_ID }}'
Expand All @@ -42,6 +48,7 @@ jobs:
job_initialize_pipeline:
runs-on: ubuntu-20.04
name: 'Initialize pipeline'
environment: 'Engineering'
steps:
- name: 'Checkout'
uses: actions/checkout@v2
Expand All @@ -67,6 +74,7 @@ jobs:
job_module_pester_validation:
runs-on: ubuntu-20.04
name: 'Static validation'
environment: 'Engineering'
steps:
- name: 'Checkout'
uses: actions/checkout@v2
Expand All @@ -83,6 +91,7 @@ jobs:
job_module_deploy_validation:
runs-on: ubuntu-20.04
name: 'Deployment validation'
environment: 'Engineering'
needs:
- job_initialize_pipeline
- job_module_pester_validation
Expand Down Expand Up @@ -115,6 +124,7 @@ jobs:
##################
job_publish_module:
name: 'Publishing'
environment: 'Engineering'
if: github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master' || github.event.inputs.prerelease == 'true'
runs-on: ubuntu-20.04
needs:
Expand Down
12 changes: 11 additions & 1 deletion .github/workflows/ms.authorization.policyassignments.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,17 @@ on:
- 'utilities/pipelines/**'
- '!utilities/pipelines/dependencies/**'

permissions:
id-token: write # OIDC
contents: read # OIDC
checks: write # enricomi/publish-unit-test-result-action
pull-requests: write # enricomi/publish-unit-test-result-action

env:
variablesPath: 'global.variables.yml'
modulePath: 'arm/Microsoft.Authorization/policyAssignments'
workflowPath: '.github/workflows/ms.authorization.policyassignments.yml'
AZURE_CREDENTIALS: ${{ secrets.AZURE_CREDENTIALS }}
ARM_CLIENT_ID: ${{ secrets.ARM_CLIENT_ID }}
ARM_SUBSCRIPTION_ID: '${{ secrets.ARM_SUBSCRIPTION_ID }}'
ARM_MGMTGROUP_ID: '${{ secrets.ARM_MGMTGROUP_ID }}'
ARM_TENANT_ID: '${{ secrets.ARM_TENANT_ID }}'
Expand All @@ -42,6 +48,7 @@ jobs:
job_initialize_pipeline:
runs-on: ubuntu-20.04
name: 'Initialize pipeline'
environment: 'Engineering'
steps:
- name: 'Checkout'
uses: actions/checkout@v2
Expand All @@ -67,6 +74,7 @@ jobs:
job_module_pester_validation:
runs-on: ubuntu-20.04
name: 'Static validation'
environment: 'Engineering'
steps:
- name: 'Checkout'
uses: actions/checkout@v2
Expand All @@ -83,6 +91,7 @@ jobs:
job_module_deploy_validation:
runs-on: ubuntu-20.04
name: 'Deployment validation'
environment: 'Engineering'
needs:
- job_initialize_pipeline
- job_module_pester_validation
Expand Down Expand Up @@ -118,6 +127,7 @@ jobs:
##################
job_publish_module:
name: 'Publishing'
environment: 'Engineering'
if: github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master' || github.event.inputs.prerelease == 'true'
runs-on: ubuntu-20.04
needs:
Expand Down
12 changes: 11 additions & 1 deletion .github/workflows/ms.authorization.policydefinitions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,17 @@ on:
- 'utilities/pipelines/**'
- '!utilities/pipelines/dependencies/**'

permissions:
id-token: write # OIDC
contents: read # OIDC
checks: write # enricomi/publish-unit-test-result-action
pull-requests: write # enricomi/publish-unit-test-result-action

env:
variablesPath: 'global.variables.yml'
modulePath: 'arm/Microsoft.Authorization/policyDefinitions'
workflowPath: '.github/workflows/ms.authorization.policydefinitions.yml'
AZURE_CREDENTIALS: ${{ secrets.AZURE_CREDENTIALS }}
ARM_CLIENT_ID: ${{ secrets.ARM_CLIENT_ID }}
ARM_SUBSCRIPTION_ID: '${{ secrets.ARM_SUBSCRIPTION_ID }}'
ARM_MGMTGROUP_ID: '${{ secrets.ARM_MGMTGROUP_ID }}'
ARM_TENANT_ID: '${{ secrets.ARM_TENANT_ID }}'
Expand All @@ -42,6 +48,7 @@ jobs:
job_initialize_pipeline:
runs-on: ubuntu-20.04
name: 'Initialize pipeline'
environment: 'Engineering'
steps:
- name: 'Checkout'
uses: actions/checkout@v2
Expand All @@ -67,6 +74,7 @@ jobs:
job_module_pester_validation:
runs-on: ubuntu-20.04
name: 'Static validation'
environment: 'Engineering'
steps:
- name: 'Checkout'
uses: actions/checkout@v2
Expand All @@ -83,6 +91,7 @@ jobs:
job_module_deploy_validation:
runs-on: ubuntu-20.04
name: 'Deployment validation'
environment: 'Engineering'
needs:
- job_initialize_pipeline
- job_module_pester_validation
Expand Down Expand Up @@ -118,6 +127,7 @@ jobs:
##################
job_publish_module:
name: 'Publishing'
environment: 'Engineering'
if: github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master' || github.event.inputs.prerelease == 'true'
runs-on: ubuntu-20.04
needs:
Expand Down
12 changes: 11 additions & 1 deletion .github/workflows/ms.authorization.policyexemptions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,17 @@ on:
- 'utilities/pipelines/**'
- '!utilities/pipelines/dependencies/**'

permissions:
id-token: write # OIDC
contents: read # OIDC
checks: write # enricomi/publish-unit-test-result-action
pull-requests: write # enricomi/publish-unit-test-result-action

env:
variablesPath: 'global.variables.yml'
modulePath: 'arm/Microsoft.Authorization/policyExemptions'
workflowPath: '.github/workflows/ms.authorization.policyexemptions.yml'
AZURE_CREDENTIALS: ${{ secrets.AZURE_CREDENTIALS }}
ARM_CLIENT_ID: ${{ secrets.ARM_CLIENT_ID }}
ARM_SUBSCRIPTION_ID: '${{ secrets.ARM_SUBSCRIPTION_ID }}'
ARM_MGMTGROUP_ID: '${{ secrets.ARM_MGMTGROUP_ID }}'
ARM_TENANT_ID: '${{ secrets.ARM_TENANT_ID }}'
Expand All @@ -42,6 +48,7 @@ jobs:
job_initialize_pipeline:
runs-on: ubuntu-20.04
name: 'Initialize pipeline'
environment: 'Engineering'
steps:
- name: 'Checkout'
uses: actions/checkout@v2
Expand All @@ -67,6 +74,7 @@ jobs:
job_module_pester_validation:
runs-on: ubuntu-20.04
name: 'Static validation'
environment: 'Engineering'
steps:
- name: 'Checkout'
uses: actions/checkout@v2
Expand All @@ -83,6 +91,7 @@ jobs:
job_module_deploy_validation:
runs-on: ubuntu-20.04
name: 'Deployment validation'
environment: 'Engineering'
needs:
- job_initialize_pipeline
- job_module_pester_validation
Expand Down Expand Up @@ -118,6 +127,7 @@ jobs:
##################
job_publish_module:
name: 'Publishing'
environment: 'Engineering'
if: github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master' || github.event.inputs.prerelease == 'true'
runs-on: ubuntu-20.04
needs:
Expand Down
Loading