{ACR} Redact refresh token from expose-token test recording - #34114
Merged
Julie Zhu (yanzhudd) merged 1 commit intoSep 23, 2026
Merged
Conversation
|
Hi Zoey Li (@lizMSFT), |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
requested review from
Bin Du (northtyphoon) and
Terence Truong (terencet-dev)
September 22, 2026 16:28
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The recording-only secret redaction is complete with no unresolved issues.
Review effort: Lite
Findings: None
What changed in this PR
Redacts an accidentally captured ACR refresh token from a test recording without changing CLI behavior.
Changes:
- Replaces the exposed token with
***.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/acr/tests/latest/recordings/test_acr_login_expose_token.yaml |
Redacts the refresh token response. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Julie Zhu (yanzhudd)
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Description
Redacts the ACR refresh token accidentally captured in the
test_acr_login_expose_tokenrecording introduced by #34053.Testing Guide
This is a recording-only change. The exposed value is replaced with the standard
***secret placeholder.History Notes
No customer-facing behavior change.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.