Repository navigation
Adding support for query parameter in Swagger UI - #1769
Merged
Abhishek Kumar (abhishekkumams) merged 32 commits intoNov 14, 2023
Merged
Conversation
Abhishek Kumar (abhishekkumams)
requested review from
Aniruddh Munde (Aniruddh25),
Jelte Fennema-Nio (JelteF),
Mathieu Tremblay (Mathos1432),
aaronburtle,
Aaron Powell (aaronpowell),
Ayush Agarwal (ayush3797),
Gledis Zeneli (gledis69),
Bhaskar Mallapragada (mbhaskar),
Milis (milismsft),
Ravi Shetye (ravishetye),
Sean Leonard (seantleonard),
Shyam Sundar J (severussundar) and
tarazou9
as code owners
October 3, 2023 12:04
Abhishek Kumar (abhishekkumams)
marked this pull request as draft
October 3, 2023 12:04
Abhishek Kumar (abhishekkumams)
marked this pull request as ready for review
October 4, 2023 16:33
Sean Leonard (seantleonard)
previously requested changes
Nov 2, 2023
Sean Leonard (seantleonard)
left a comment
Contributor
There was a problem hiding this comment.
suggestions on making tests more readable and less prone to flakiness.
Co-authored-by: Sean Leonard <sean.leonard@microsoft.com>
Co-authored-by: Sean Leonard <sean.leonard@microsoft.com>
Co-authored-by: Sean Leonard <sean.leonard@microsoft.com>
Co-authored-by: Sean Leonard <sean.leonard@microsoft.com>
Co-authored-by: Sean Leonard <sean.leonard@microsoft.com>
Co-authored-by: Sean Leonard <sean.leonard@microsoft.com>
….com/Azure/data-api-builder into dev/abhishekkuma/open-api-documentor
Aniruddh Munde (Aniruddh25)
requested changes
Nov 7, 2023
Aniruddh Munde (Aniruddh25)
left a comment
Collaborator
There was a problem hiding this comment.
Some nits, and question on providing only $select for FindById..
Co-authored-by: Sean Leonard <sean.leonard@microsoft.com>
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Abhishek Kumar (abhishekkumams)
requested review from
Aniruddh Munde (Aniruddh25) and
Sean Leonard (seantleonard)
November 13, 2023 18:42
aaronburtle
reviewed
Nov 14, 2023
Aniruddh Munde (Aniruddh25)
approved these changes
Nov 14, 2023
Aniruddh Munde (Aniruddh25)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks for addressing all the feedback!
Abhishek Kumar (abhishekkumams)
dismissed
Sean Leonard (seantleonard)’s stale review
November 14, 2023 16:53
updated the tests
Abhishek Kumar (abhishekkumams)
deleted the
dev/abhishekkuma/open-api-documentor
branch
November 14, 2023 16:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
$filter,$orderBy,$first, and$afterwill be available in swagger UI for GET/GET_ALL REST requests in Table/Views.How was this tested?
Screenshots
GET request will have all the query parameters
POST/PUT/PATCH/DELETE will not have the above query parameters
Input parameters for Stored procedure, depending on the stored procedure definition