Repository navigation
minicoro: suppress the MSVC padding warning for _mco_fiber - #1297
Open
Quchaosheng wants to merge 1 commit into
Open
Quchaosheng wants to merge 1 commit into
Quchaosheng wants to merge 1 commit into
Conversation
C4324 is raised because the reverse-engineered CONTEXT field forces padding; the layout is intentional and the warning is not actionable. Keep it scoped to the struct.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSVC with
/W4 /WXreports C4324 for_mco_fiberbecause theCONTEXTfield forces alignment padding. The layout is intentional (it mirrors the Win32 fiber layout), so suppress the warning around this struct only, and restore it afterwards.Fixes #1292.