Repository navigation
Refuse unsafe process selection from a file target - #99
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Cheat Engine has a file-as-process target open, calling
openProcesscan report success while the memory backend remains unusable.SelectAndObservenow observes the current target first and returnsFileAsProcessTargetbefore attempting that unsafe transition. Missing, failed, or malformed observations also refuse selection; an unattached or ordinary process target still follows the existing confirmed-selection path.The guard preserves the selected file and the caller's Lua stack. It does not reset Cheat Engine callbacks or claim to repair the native file-to-process transition; callers must use Cheat Engine's process selector or restart the host.
Validation: 83 focused NativeLua tests and all 1,223 Release Engine tests passed. The full SDK Release solution build passed with zero warnings or errors. Regression coverage distinguishes preflight refusal from a file-target observation returned after an attempted selection.