Repository navigation
fix(mobile): new thread text no longer jumps - #17
Open
Claudesaul wants to merge 1 commit into
Open
Claudesaul wants to merge 1 commit into
Claudesaul wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the iPhone, the "What should we build" text jumped about 29pt up just as the New thread screen finished sliding in. It now opens in its final spot.
The text is centered between the header and the composer, and both start out too small while the screen slides in. The composer's first guess of 94pt leaves out the checkout and branch row, and it's really 141pt. The header reports 106pt, then 116pt. When the real numbers arrived, the text moved. Now it starts from the settled sizes, so nothing moves it. Typing a long draft or opening the keyboard still pushes it up as before.
I found no open issue or PR for this.
Checked on an iPhone 18 Pro Max simulator on iOS 27: the text's top and bottom limits stay at 116pt and 166pt from the first render on, where before they went from 106 and 118 to 116 and 165. The simulator measures so fast that it only showed a jump of about 9pt, so I couldn't see the full 29pt from the phone. The fix hasn't been tried on a real iPhone yet. iPad and Android weren't run. The header change is iOS only.