determine whether "map error" is detectable #41

Activity

1. davidchambers commented on Jun 1, 2017

   

   davidchambers

   on Jun 1, 2017

   ContributorAuthor

   More actions

   I don't think detecting a "map error" is possible, but an even better approach would be to validate the latitude and longitude values provided in the Markdown file. According to Google Static Maps Developer Guide:

   Latitude and longitude values must correspond to a valid location on the face of the earth. Latitudes can take any value between -90 and 90 while longitude values can take any value between -180 and 180. If you specify an invalid latitude or longitude value, your request will be rejected as a bad request.

   It should be possible to write some Ruby code to validate these values. If invalid values are provided, Travis would fail the pull request.
2. vsmart commented on Jul 3, 2018

   

   vsmart

   on Jul 3, 2018

   Member

   More actions

   I see that the latitude/longitude values as min/max are encoded in the validate-file logic :
   https://github.com/ClojureBridge/clojurebridge.github.io/blob/master/validate-yaml.cljs#L20-L21

   I think this means that the build would fail if incorrect values are given and that we can close here. cc @davidchambers
3. davidchambers commented on Jul 3, 2018

   

   davidchambers

   on Jul 3, 2018

   ContributorAuthor

   More actions

   Good point, Franka. :)
4. davidchambers

   closed this as completedon Jul 3, 2018