You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Impossible to profile binary with exit status 1 #242
I'd be happy to pick this up. Two quick design questions before I send a PR:
Flag name — following hyperfine's convention cited above, my default would be -i / --ignore-failure. Any
preference for a different naming?
Scope — the cmd_status != 0 bail lives in src/executor/valgrind/measure.rs, and there's a symmetric !status.success() check in src/executor/wall_time/executor.rs. Would you like the flag to apply to both executors,
or keep it scoped to codspeed exec only?
Happy to open a draft PR first if you'd prefer to review the shape before I add tests.
Activity
GuillaumeLagrange commentedon Feb 12, 2026
That would definitely be something we should do, thanks for the feedback!
yaowubarbara commentedon Apr 12, 2026
I'd be happy to pick this up. Two quick design questions before I send a PR:
Flag name — following hyperfine's convention cited above, my default would be
-i / --ignore-failure. Anypreference for a different naming?
Scope — the
cmd_status != 0bail lives insrc/executor/valgrind/measure.rs, and there's a symmetric!status.success()check insrc/executor/wall_time/executor.rs. Would you like the flag to apply to both executors,or keep it scoped to
codspeed execonly?Happy to open a draft PR first if you'd prefer to review the shape before I add tests.
feat(cli): add --ignore-failure to allow non-zero exit codes
yaowubarbara commentedon Apr 12, 2026
I've opened #286 as a draft to show the shape, happy to rename the flag or narrow the scope based on your preference before marking it ready.
feat(cli): add --ignore-failure to exec command