Skip to content

Footer Email Reference #235

Description

@TangoYankee

Feature

Increase maintainability of references in footer

Affected Area

footer, lines 58 & 59

Description

'href' for email uses a liquid reference to the configuration file. However, the associated 'text' is hard-coded. hard-coding could be replaced with:

'{{site.email}}'

Activity

  1. TangoYankee commented on Jul 16, 2018

    @TangoYankee
    Author

    Note this works for ruby version 2.3. It may break for 2.5

  2. jordangov commented on Oct 4, 2018

    @jordangov
    Contributor

    Hey @TangoYankee ! Thanks for the report. I think I recall trying to do this at one point and it not working for some reason. That said, if it works, we should do it! PRs welcome. ;)

  3. added a commit that references this issue on Nov 15, 2019
  4. tinjaw commented on Aug 26, 2020

    @tinjaw

    I believe this is resolved and should be closed? Is that true?

  5. zacnomore commented on Sep 21, 2020

    @zacnomore

    href: mailto:{{site.email}}

    Agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions