Repository navigation
Add getBestBlockId RPC method - #320
Merged
Merged
Conversation
Contributor
|
@redongjun Could you update the spec file along with? https://github.com/CodeChain-io/codechain/blob/master/spec/JSON-RPC.md#chain_getbestblockid |
Contributor
Author
|
@joojis it's OK Could you know me why the order of field (hash and number) is reversed on a RPC response as below? |
Contributor
|
@redongjun I was unintentional for that. You can change the order in the spec. |
kakao-jun-e
force-pushed
the
release/bestblockid
branch
from
July 4, 2018 11:32
f030ef6 to
6fc2ffe
Compare
joojis
self-requested a review
July 5, 2018 01:21
joojis
reviewed
Jul 5, 2018
| ``` | ||
|
|
||
| ## chain_getBestBlockId | ||
| (not implemented yet) Gets the number and the hash of the best block. |
Contributor
There was a problem hiding this comment.
There is 1 more "not implemented" note in the List of Methods (line 84)
kakao-jun-e
force-pushed
the
release/bestblockid
branch
from
July 5, 2018 04:32
64adffe to
f20f841
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #290