Repository navigation
Check builder-frontend formatting and types in the test suite - #589
Merged
Merged
Conversation
Formatting only: the 29 files under src that didn't match Prettier's defaults. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The builder-frontend suite, which CI runs, now also checks Prettier formatting and type-checks src against a per-file baseline of the errors that exist today, failing only when a file gets more. Lodash type definitions remove 13 of those errors, and skipLibCheck leaves library type definitions to their authors, so dependency updates can't trip the baseline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
prestoncabe
force-pushed
the
builder-frontend-guardrails
branch
from
November 5, 2026 19:56
b421d8d to
ce9e30d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Until now CI only ran builder-frontend's tests. Prettier was partly applied (29 files under
srcdidn't match), andtscreported 187 errors, so neither could catch problems in new code.The type check is a per-file ratchet:
The baseline drops from 187 to 151 errors:
@types/lodashand@types/lodash.debounceremove 13 errors.skipLibCheckremoves the errors inside library.d.tsfiles. Otherwise a dependency bump (Dependabot included) could fail the ratchet.Commits:
skipLibCheckand the suite wiring. The README documents the new scripts.Evidence
prettier --check srclisted 29 files, andtscreported 187 errors with no way to tell which were new.After:
devbox run test -- builder-frontend:npm run buildstill succeeds withskipLibCheck; Vite doesn't type-check.Merge Danger
Door: two-way
Revert the second commit to remove the checks. The formatting commit is harmless to keep.
Blast Radius: builder-frontend PRs
Open builder-frontend PRs now need Prettier-formatted code and no new type errors in the files they touch. Branches that touch any of the 29 reformatted files may need a rebase.
🤖 Generated with Claude Code