Skip to content

[WIP][#571] Improve library benefit picker - #592

Draft
sahilds1 wants to merge 1 commit into
CodeForPhilly:mainfrom
sahilds1:571-improve-library-benefit-picker
Draft

sahilds1 wants to merge 1 commit into
CodeForPhilly:mainfrom
sahilds1:571-improve-library-benefit-picker

Conversation

@sahilds1

@sahilds1 sahilds1 commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Frontend only: match by name instead of recording sourceBenefitId in the backend. The first plan added a sourceBenefitId field on the backend. The issue is labeled good first issue, frontend and quick win, so we scaled it back. Matching by name needs no backend change and also works for benefits imported before this change. The trade-offs:

    • renaming an imported benefit makes the library version show up in the picker again, which is how the picker behaved before this change;
    • a custom benefit that happens to share a library benefit's name hides that library benefit.
  • Left out for now:

    • the "show anyway behind an extra click" idea from the issue note;
    • a backend block on duplicate imports;
    • the sourceBenefitId approach, which could be a follow-up issue if renames turn out to confuse people.

GitHub Issue: #571

Verification

Documentation impact

  • I updated affected documentation, or this change does not alter user-visible behavior, commands, configuration, APIs, or contributor workflows.

@sahilds1 sahilds1 self-assigned this Nov 6, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant