Skip to content

Identify if a string is a number: .NET 10, empty-string guard, stricter double check #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vladimir-pecanac-main merged 2 commits into from
Oct 9, 2026
Merged

Identify if a string is a number: .NET 10, empty-string guard, stricter double check #2275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14116ab
Identify if a string is a number: .NET 10, empty-string guard, strict…
vladimir-pecanac-main Oct 8, 2026
bded4b3
Merge branch 'main' into seo/87852-csharp-identify-if-a-string-is-a-n…
vladimir-pecanac-main Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions strings-csharp/IdentifyIfStringIsANumber/BenchmarkRunner/BenchmarkRunner.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="BenchmarkDotNet" Version="0.13.5" />
<PackageReference Include="BenchmarkDotNet" Version="0.15.8" />
</ItemGroup>

<ItemGroup>
Expand Down
17 changes: 9 additions & 8 deletions strings-csharp/IdentifyIfStringIsANumber/BenchmarkRunner/StringIsANumberBenchmark.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,47 +8,48 @@ namespace BenchmarkRunner;
[MemoryDiagnoser]
public class StringIsANumberBenchmark
{
private string value = "123456789";
[Params("123456789", "a12345678")]
public string Value { get; set; } = string.Empty;

[Benchmark]
public void IntTryParse()
{
StringIsANumberChecker.IntTryParse(value);
StringIsANumberChecker.IntTryParse(Value);
}

[Benchmark]
public void DoubleTryParse()
{
StringIsANumberChecker.DoubleTryParse(value);
StringIsANumberChecker.DoubleTryParse(Value);
}

[Benchmark]
public void UsingRegex()
{
StringIsANumberChecker.UsingRegex(value);
StringIsANumberChecker.UsingRegex(Value);
}

[Benchmark]
public void UsingCompiledRegex()
{
StringIsANumberChecker.UsingCompiledRegex(value);
StringIsANumberChecker.UsingCompiledRegex(Value);
}

[Benchmark]
public void UsingCharIsDigit()
{
StringIsANumberChecker.UsingCharIsDigit(value);
StringIsANumberChecker.UsingCharIsDigit(Value);
}

[Benchmark]
public void UsingCharIsDigitWithForeach()
{
StringIsANumberChecker.UsingCharIsDigitWithForeach(value);
StringIsANumberChecker.UsingCharIsDigitWithForeach(Value);
}

[Benchmark]
public void UsingCharIsBetween09()
{
StringIsANumberChecker.UsingCharIsBetween09(value);
StringIsANumberChecker.UsingCharIsBetween09(Value);
}
}
10 changes: 5 additions & 5 deletions ...fStringIsANumber/IdentifyIfAStringIsANumber.Tests/IdentifyIfAStringIsANumber.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>

Expand All @@ -10,13 +10,13 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.5.0" />
<PackageReference Include="xunit" Version="2.4.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.10.1" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="4.0.0">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="coverlet.collector" Version="3.2.0">
<PackageReference Include="coverlet.collector" Version="10.1.0">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
Expand Down
7 changes: 7 additions & 0 deletions ...-csharp/IdentifyIfStringIsANumber/IdentifyIfAStringIsANumber.Tests/StringIsNumberTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ public class StringIsNumberTests
[InlineData("abc", false)]
[InlineData("414aa", false)]
[InlineData("١٢٣", false)]
[InlineData("", false)]
public void GivenAString_WhenUsingIntTryParseMethod_ThenTryToParseIt(string value, bool expectedResult)
{
var result = StringIsANumberChecker.IntTryParse(value);
Expand All @@ -23,6 +24,7 @@ public void GivenAString_WhenUsingIntTryParseMethod_ThenTryToParseIt(string valu
[InlineData("abc", false)]
[InlineData("414aa", false)]
[InlineData("١٢٣", false)]
[InlineData("", false)]
public void GivenAString_WhenUsingCharIsDigit_ThenTryToParseIt(string value, bool expectedResult)
{
var result = StringIsANumberChecker.UsingCharIsDigit(value);
Expand All @@ -37,6 +39,7 @@ public void GivenAString_WhenUsingCharIsDigit_ThenTryToParseIt(string value, boo
[InlineData("abc", false)]
[InlineData("414aa", false)]
[InlineData("١٢٣", false)]
[InlineData("", false)]
public void GivenAString_WhenUsingDoubleTryParse_ThenTryToParseIt(string value, bool expectedResult)
{
var result = StringIsANumberChecker.DoubleTryParse(value);
Expand All @@ -51,6 +54,7 @@ public void GivenAString_WhenUsingDoubleTryParse_ThenTryToParseIt(string value,
[InlineData("abc", false)]
[InlineData("414aa", false)]
[InlineData("١٢٣", false)]
[InlineData("", false)]
public void GivenAString_WhenUsingRegex_ThenTryToParseIt(string value, bool expectedResult)
{
var result = StringIsANumberChecker.UsingRegex(value);
Expand All @@ -65,6 +69,7 @@ public void GivenAString_WhenUsingRegex_ThenTryToParseIt(string value, bool expe
[InlineData("abc", false)]
[InlineData("414aa", false)]
[InlineData("١٢٣", false)]
[InlineData("", false)]
public void GivenAString_WhenUsingCompiledRegex_ThenTryToParseIt(string value, bool expectedResult)
{
var result = StringIsANumberChecker.UsingCompiledRegex(value);
Expand All @@ -79,6 +84,7 @@ public void GivenAString_WhenUsingCompiledRegex_ThenTryToParseIt(string value, b
[InlineData("abc", false)]
[InlineData("414aa", false)]
[InlineData("١٢٣", false)]
[InlineData("", false)]
public void GivenAString_WhenUsingCharIsDigitWithForeach_ThenTryToParseIt(string value, bool expectedResult)
{
var result = StringIsANumberChecker.UsingCharIsDigitWithForeach(value);
Expand All @@ -93,6 +99,7 @@ public void GivenAString_WhenUsingCharIsDigitWithForeach_ThenTryToParseIt(string
[InlineData("abc", false)]
[InlineData("414aa", false)]
[InlineData("١٢٣", false)]
[InlineData("", false)]
public void GivenAString_WhenUsingCharIsBetween09_ThenTryToParseIt(string value, bool expectedResult)
{
var result = StringIsANumberChecker.UsingCharIsBetween09(value);
Expand Down
2 changes: 1 addition & 1 deletion ...rp/IdentifyIfStringIsANumber/IdentifyIfAStringIsANumber/IdentifyIfAStringIsANumber.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>
Expand Down
20 changes: 19 additions & 1 deletion strings-csharp/IdentifyIfStringIsANumber/IdentifyIfAStringIsANumber/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,26 @@
Console.WriteLine($" * {item,-15} ====> {StringIsANumberChecker.UsingRegex(item)}");
}

Console.WriteLine("Using Char.IdDigit:");
Console.WriteLine("Using char.IsAsciiDigit():");
foreach (var item in values)
{
Console.WriteLine($" * {item,-15} ====> {StringIsANumberChecker.UsingCharIsDigit(item)}");
}

Console.WriteLine("Using compiled Regex:");
foreach (var item in values)
{
Console.WriteLine($" * {item,-15} ====> {StringIsANumberChecker.UsingCompiledRegex(item)}");
}

Console.WriteLine("Using char.IsAsciiDigit() with foreach:");
foreach (var item in values)
{
Console.WriteLine($" * {item,-15} ====> {StringIsANumberChecker.UsingCharIsDigitWithForeach(item)}");
}

Console.WriteLine("Using character value comparison:");
foreach (var item in values)
{
Console.WriteLine($" * {item,-15} ====> {StringIsANumberChecker.UsingCharIsBetween09(item)}");
}
11 changes: 9 additions & 2 deletions ...ngs-csharp/IdentifyIfStringIsANumber/IdentifyIfAStringIsANumber/StringIsANumberChecker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ public static bool IntTryParse(string stringValue)

public static bool DoubleTryParse(string stringValue)
{
return double.TryParse(stringValue, NumberStyles.Any, CultureInfo.InvariantCulture, out _);
return double.TryParse(stringValue, NumberStyles.Float | NumberStyles.AllowThousands,
CultureInfo.InvariantCulture, out _);
}

public static bool UsingRegex(string stringValue)
Expand All @@ -33,11 +34,14 @@ public static bool UsingCompiledRegex(string stringValue)

public static bool UsingCharIsDigit(string stringValue)
{
return stringValue.All(char.IsAsciiDigit);
return !string.IsNullOrEmpty(stringValue) && stringValue.All(char.IsAsciiDigit);
}

public static bool UsingCharIsDigitWithForeach(string stringValue)
{
if (string.IsNullOrEmpty(stringValue))
return false;

foreach (var c in stringValue)
{
if (!char.IsAsciiDigit(c))
Expand All @@ -48,6 +52,9 @@ public static bool UsingCharIsDigitWithForeach(string stringValue)

public static bool UsingCharIsBetween09(string stringValue)
{
if (string.IsNullOrEmpty(stringValue))
return false;

foreach (var c in stringValue)
{
if (c is < '0' or > '9')
Expand Down
Loading