Repository navigation
San 6078 - #2029
San 6078#2029damienrunnable wants to merge 13 commits into
Conversation
* master: (134 commits) Replacing the npm tokens 12.5.1 update model Added catch to prevent keymaker from preventing build process 12.5.0 Revert "Revert "San 6200 add ssh keys"" Remove session user from call Revert "San 6200 add ssh keys" Add a migrate-and-start command Use saveAsync() fix seedVersions for callback remove unused func param add migration stuff into readme fix migrate up again 12.4.3 add migrate-up to start 12.4.2 Added newlines and added comments Still messed up which functions went where Changing invalid mount type. r to ro ...
| return portList | ||
| } | ||
|
|
||
| ImageService.getImageDataFromJob = function (job) { |
There was a problem hiding this comment.
It seems that this method name can be changed. You are not getting image data from any job, you are getting from a particular one.
There was a problem hiding this comment.
Also, maybe we don't even need to put it in the service. Can we keep it in to the worker?
There was a problem hiding this comment.
I don't mind keeping this separate since the worker is already bloated.
podviaznikov
left a comment
There was a problem hiding this comment.
Looks good. Few minor questions
|
|
||
| ImageService.getImageDataFromJob = function (job) { | ||
| const log = ImageService.logger.child({ | ||
| method: 'getImageDataFromJob' |
| return portList | ||
| } | ||
|
|
||
| ImageService.getImageDataFromJob = function (job) { |
There was a problem hiding this comment.
Also, maybe we don't even need to put it in the service. Can we keep it in to the worker?
| } | ||
| } | ||
|
|
||
| if (imageData) { |
There was a problem hiding this comment.
is there a case where we don't get image data? we should always have it here.
| @@ -0,0 +1,56 @@ | |||
| /** | |||
| * @module lib/models/services/image-service | |||
There was a problem hiding this comment.
nit: rename to docker image service
| */ | ||
| 'use strict' | ||
|
|
||
| require('loadenv')('models/services/infracode-version-service') |
| return portList | ||
| } | ||
|
|
||
| ImageService.getImageDataFromJob = function (job) { |
There was a problem hiding this comment.
Saving the image data on the context version.