Repository navigation
Custom inference session for improved ONNX model handling - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
This PR introduces a custom inference session class that improves how ONNX inference is handled within TransformersPHP. Previously, the original inference session from ankane/onnnxruntime-php processed inputs and outputs as flat arrays. Since TransformersPHP primarily works with tensors, this created extra conversion steps.
Here's how the original process worked:
With the new custom inference session, these unnecessary conversions and overheads are eliminated, conserving memory and improving performance. Now, the session accepts a tensor as input and returns a tensor as output, streamlining the process to:
Additionally, the custom inference session resolves an issue with zero-sized tensors. The previous approach struggled with zero-sized arrays, losing contextual information about their shape. By working directly with tensors, the new inference session retains shape information even for zero-sized tensors. This allows for accurate memory allocation and shape management, eliminating the need for manual adjustments for attention masks in decoder models.
In summary, this PR optimizes the handling of inputs and outputs in ONNX inference sessions, reducing conversion overhead and improving memory management and performance for larger model inputs and outputs.