Skip to content

fix: ConnectedForm linting errors - #3384

Merged
LinKCoding merged 1 commit into
cass-gmt-1473-betafrom
kl-gmt-1473-form-validation-lint-fixes
Jun 24, 2026
Merged

LinKCoding merged 1 commit into
cass-gmt-1473-betafrom
kl-gmt-1473-form-validation-lint-fixes

Conversation

@LinKCoding

@LinKCoding LinKCoding commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Overview

Fixes some linting errors that surfaced since this branch upgrades ESLint

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GMT-1473
  • Version plan added/updated (or not needed)
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Check that tests pass
  2. ...
  3. Profit?

PR Links and Envs

N/A

@nx-cloud

nx-cloud Bot commented Jun 24, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 22bce52


☁️ Nx Cloud last updated this comment at 2026-06-24 18:21:42 UTC

@codecademydev

Copy link
Copy Markdown
Collaborator

📬 Published Alpha Packages:

Package Version npm Diff
@codecademy/gamut 72.2.2-alpha.9be880.0 npm diff
@codecademy/gamut-icons 9.57.10-alpha.9be880.0 npm diff
@codecademy/gamut-illustrations 0.58.16-alpha.9be880.0 npm diff
@codecademy/gamut-kit 3.0.6-alpha.9be880.0 npm diff
@codecademy/gamut-patterns 0.10.35-alpha.9be880.0 npm diff
@codecademy/gamut-styles 20.0.3-alpha.9be880.0 npm diff
@codecademy/gamut-tests 6.0.6-alpha.9be880.0 npm diff
@codecademy/variance 0.26.2-alpha.9be880.0 npm diff
eslint-plugin-gamut 2.4.4-alpha.9be880.0 npm diff

@github-actions

Copy link
Copy Markdown
Contributor

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.95%. Comparing base (bfc44ae) to head (22bce52).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           cass-gmt-1473-beta    #3384      +/-   ##
======================================================
- Coverage               90.33%   89.95%   -0.38%     
======================================================
  Files                     379      271     -108     
  Lines                    6226     5697     -529     
  Branches                 2044     1920     -124     
======================================================
- Hits                     5624     5125     -499     
+ Misses                    594      564      -30     
  Partials                    8        8              
Flag Coverage Δ
pull-request 89.95% <100.00%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LinKCoding
LinKCoding marked this pull request as ready for review June 24, 2026 18:28
@LinKCoding
LinKCoding requested a review from a team as a code owner June 24, 2026 18:28
@LinKCoding
LinKCoding merged commit 1275389 into cass-gmt-1473-beta Jun 24, 2026
13 checks passed
dreamwasp added a commit that referenced this pull request Aug 20, 2026
* beta: vanilaa 19'

* format

* .spec

* test

* ref check

* type widening + formatting

* revert type widening

* 18/19

* terst build

* update react-hook-form

* put connected form back

* try re-creating ref type in cast;

* ts upgrade test

* test typescript

* lint + format

* test in ci

* start fixing test failures

* add release plan

* chore: align babel-plugin-macros and component-test-setup for syncpack

Made-with: Cursor

* dedupe yrn

* lint fix

* release plan update

* update plan

* fix failing tests from merge

* fix popover refs + Dialog/Modal

* resolve weird state post merge, id||name was reverted back to fieldName

* fix: ConnectedForm linting errors  (#3384)

fixed linting errors re: connectedForm

* fix tag type

* fix mdx

---------

Co-authored-by: Kenny Lin <kenny.lin.91@gmail.com>
Co-authored-by: Amy Resnik <aresnik11@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants