Skip to content

chore(openspec): verify-and-tick sweep (launchpad, part 1) - #832

Open
rubenvdlinde wants to merge 2 commits into
developmentfrom
chore/openspec-sweep-1
Open

rubenvdlinde wants to merge 2 commits into
developmentfrom
chore/openspec-sweep-1

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Verify-and-tick sweep of launchpad's open OpenSpec changes (decision 141). No code, schema or test was edited; only tasks.md files, the archive moves, and one new main spec.

Ticked, with the evidence file in each task line

  • fix-group-dashboard-admin-auth-attribute: tasks 1-8 and 12 (DashboardApiController, PageController, AdminSettingsController, DashboardApiControllerGroupSharedTest, AdminControllerGroupOrderTest). Tasks 9-11 marked "code exists, test missing" (no attribute test on AdminSettingsController).
  • add-dashboard-sharing-e2e-coverage: tasks 1-7 (tests/e2e/dashboard-sharing.spec.ts, spec @e2e lines). Task 8 live.
  • harden-activity-debounce-cache-reliability: tasks 1-4, 6-8 (DebounceHelper and its test). Task 5 marked "test missing".
  • 2026-04-30-dashboard-sharing-followups: 1.3, 1.4, 2.1, 2.2, 2.6, 3.1-3.6, 4.1-4.3, 5.1-5.4, 5.7. Gaps left open: no Notifier test, no ownership counters (5.6), revokeAllForRecipient missing from src/services/api.js (4.4), no docs/sharing.md.
  • dashboard-switcher: tasks 3, 4, 6, 7, 10, 12, 14, 15, 17, against DashboardSwitcherSidebar.vue and its Vitest file (the shipped component is not named DashboardSwitcher.vue as the tasks say).

Live tasks marked "(live pass, decision 139)"

engagement-activity-digest 5, launchpad-manifest-tier-3 (E2E leg), fix-group-dashboard-admin-auth-attribute 15, add-dashboard-sharing-e2e-coverage 8, plus the live tasks of the six archived changes.

Archived (live-only remaining, code complete)

adopt-connection-registry (new spec app-connections), cross-app-attention-feed (spec already in sync), mijn-werkdag-template, mijn-werkdag-v3, shipped-template-update, start-page-without-navigation-panel (no deltas, --skip-specs). openspec validate --specs: 1 failure (groupfolder-storage-backend) before and after, 83 passed after.

Needs a decision

Q-launchpad-S1 in QUESTIONS.md: 2026-04-30-dashboard-sharing-followups is a duplicate of an already archived copy.

Not touched

Changes the build lane touched (dashboards-and-who-may-see-them, fix-l10n-domain-mismatch-mydash-calls), and about 35 changes whose code is not on development (catalogue, bookmark import, discovery, office tiles, announcements, communities, per-dashboard theme, search shortcuts, public start page, tile launch types, open behaviour, sorting, office networks, map, publication, scheduled exports, calculated fields, MCP, meeting actions, mobile, file access, enterprise security, AI summary widgets, bbv templates, embedded analytics, drill-down, REST API reference, ResponseHelper, category getter rename). e2e-coverage-programme is an ongoing tracker.

@rubenvdlinde
rubenvdlinde requested a review from Rem-Dam as a code owner October 10, 2026 08:32
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/launchpad @ 7ec94b0

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
format ❌
check-schema-l10n ✅
composer ✅ ✅ 107/107
npm ✅ ✅ 636/636
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ⏭️ not run for this diff — no file in this diff matches the code globs, and none carries a source extension — the heavy tier has nothing to decide about it.
Newman ✅ 224/224
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-10-10 08:58 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant