Repository navigation
feat: build open OpenSpec changes (launchpad, part 2) - #833
Open
rubenvdlinde wants to merge 8 commits into
Open
rubenvdlinde wants to merge 8 commits into
rubenvdlinde wants to merge 8 commits into
Conversation
…vitest run passed
… activity widget, in-widget filter, personal layer sweep (l10n + test fixes)
…-widget filter specs for the live pass; tick built tasks
…ague endpoint contract test)
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
October 10, 2026 08:35
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 107/107 | |||
| npm | ✅ | ✅ 636/636 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 1975/1975 (no test failed, the job failed for another reason — see its log) | ||||
| Newman | ✅ 224/224 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-10 09:00 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of building launchpad's open OpenSpec changes (decisions 121-124). Cut from #826's head; development (with #826 merged) is merged in.
Built
dashboards-and-who-may-see-them, partly built (sections 1, 4, 5, 6; no matrix rows)
orphaned_personal_layer_entries. The dailyOrphanedDataCleanupJobnow callsPersonalLayerService::pruneOrphans(), which had no caller before.orphaned-data-cleanupspec data model updated to list five shipped categories, three of them Tier-A.CriticalActionPerformedEvent). A person reads their own on the personal settings page, with no audit entry. Figures are counts per activity type and a calendar of intensity per day. Events only, never hours. CSV export totals match the screen. Admin tab "Activity reporting".colleague-activity): what colleagues did that reached the reader. Dashboard events are rechecked againstcanViewDashboard()and counted after the filter.tests/e2e/api-direct/activity-reporting.api.spec.ts,tests/e2e/widget-row-filter.spec.ts.Also: fix-l10n-domain-mismatch task 8 ticked (the checkpoint vitest run).
ActivitySettingsTestnow reads info.xml as a string, because under the Nextcloud bootstrapsimplexml_load_file()returned false (the stable35 PHPUnit red on #826). That fix landed with #826.Still owed
tests/e2e/seed.sh, user e2e-grantee),npx playwright test tests/e2e/widget-row-filter.spec.ts tests/e2e/api-direct/activity-reporting.api.spec.ts. Check admin_audit's log for one "LaunchPad activity report read" line per colleague read.Checks (local, on this head's code)
composer check:strict: lint, phpcs (0 errors), psalm, phpstan and PHPUnit (1974 tests, OK) all passed. phpmd found 5 new findings, now fixed. phpmd on the changed files was rerun: exit 0 (both rulesets).npm run lint0.check:l10n-parity0.check:schema-l10n0.check:manifest0. Full vitest 0 (121 files, 971 tests).formatexit 1: inherited (src/__tests__/App.navigationPanel.spec.js, red on development too).src/manifest.json, and feat: build open OpenSpec changes (launchpad, part 1) #826 showed the same.