Repository navigation
feat(tiles): discover the apps this server runs and place one as a tile (LpTegelToevoegen, part 1) - #883
Merged
Conversation
…places a tile GET /api/tiles/discover answers the caller's own Nextcloud app menu, minus LaunchPad, behind the new tile.discover action. The widget picker gets a Discovered on this server section, searchable, marking the apps already on the dashboard; a click places a tile through the normal tile path. First section of board LpTegelToevoegen. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
October 23, 2026 03:36
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 107/107 | |||
| npm | ❌ | ✅ 636/636 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-10-23 04:38 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First section of board LpTegelToevoegen: "Discovered on this server" in the add-widget picker. Openspec change
launcher-discover-server-services, tasks 1 to 4.What changes
ServiceDiscoveryServicereads the caller's own Nextcloud app menu (INavigationManager::getAll('link')), minus LaunchPad. Group restrictions and enabled state come from Nextcloud; no Docker socket, container labels or AppAPI data are read (REQ-DISC-003).GET /api/tiles/discover(#[NoAdminRequired], no id parameter) behind the newtile.discoveraction, seeded["admin", "@all"].applink when the address is the app's own page, else aurllink. Adding again is still allowed.Not in this PR
Verification
COMPOSER_PROCESS_TIMEOUT=0 composer check:strict: exit 0 (ALL CHECKS PASSED).npm run lint: exit 0 (5 inherited jsdoc warnings: 3 insrc/components/Workspace/config/DetailsTab.vue, 2 insrc/services/api.json a function this PR does not touch).ServiceDiscoveryServiceTest, 3 discover cases inTileApiControllerTest) and vitest (WidgetPickerModal.discovered.spec.js, 8 tests) fail on development and pass here; modal and view suites green (122 tests). l10n parity OK.AI disclosure: built with Claude Code (claude-opus-5-5); reviewed by the lane, to be reviewed by a human before merge.