fix(scheduler): fail-open coalesce when tick has not completed recently - #2233
Merged
Merged
Conversation
When push-burst coalescing is enabled, defer synchronize-triggered review dispatch only while a coalesce tick completed within the last 600s (2× the 5-minute cron interval). Query the central .github repository for tick runs, not the target PR repository, and dispatch immediately when no recent tick exists so reviews never depend solely on a schedule that may not fire. Co-authored-by: Cursor <cursoragent@cursor.com>
Add unit tests for coalesce_tick_max_age_seconds, recent_coalesce_tick_completed, and dispatch_opencode_review fail-open when no recent tick completed. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Lead merge authorization (run_a9475d4b375c): Admin-merging ahead of queued CI. Local evidence on head `6f79973`:
Merged ahead of org queue saturation. |
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OPENCODE_REVIEW_COALESCE_ENABLEDis true, defer synchronize-triggered review dispatch only while a coalesce tick completed within the last 600s (2× the 5-minute cron interval)..githubrepository, not the target PR repository.Test plan
pytest tests/test_pr_review_merge_scheduler.py -k coalesce_tickOPENCODE_REVIEW_COALESCE_ENABLEDonly after ≥3 ticks and one push burst verify fail-open + tick dispatchMade with Cursor