Skip to content

Adding the MCCD package - #343

Merged
sfarrens merged 28 commits into
masterfrom
dev_mccd_tobias
Nov 3, 2020
Merged

sfarrens merged 28 commits into
masterfrom
dev_mccd_tobias

Conversation

@tobias-liaudat

Copy link
Copy Markdown
Member

Main PR to add all of the MCCD package into the pipeline.

Solves Issue #303 and Issue #108 .

Allows to start the solving of the Issue #329 .

  • Several modules are added:
    -- mccd_preprocessing_runner.py
    -- mccd_fit_runner.py
    -- mccd_fit_val_runner.py
    -- mccd_val_runner.py
    -- mccd_interp_runner.py
    -- mccd_merge_starcat_runner.py
    -- mccd_plots_runner.py
  • Documentation over the modules is provided in /shapepipe/docs/wiki/module_docs/mccd_instructions.md.
  • A MCCD config file is provided in /example/test_mccd/.
    -- Documentation of MCCD specific parameters can be found within the MCCD config file.
  • Shapepipe's config files are added for three use cases in /example/test_mccd/.
  • More info in the MCCD package can be found in the MCCD repository.
  • Dependencies of the MCCD packages as the package itself were added.
    -- Specially the pysap package.

Bear in mind that as the MCCD PSF modelling method builds one model per exposure and the input files come as one file per exposure per CCD, the preprocessing is needed so that the training stars can be merged. Also, some of the differences in the handling of files are a consequence of this fact.

There is no need to preprocess the files to perform the interpolation. mccd_interp_runner.py should allow to interpolate as it was done with the PSFEx interpolator.

In order to validate the model and calculate validation statistics and/or plots it is necessary to go through the mccd_fit_val_runner.py or the mccd_val_runner.py.

Comment thread docs/wiki/module_docs/mccd_instructions.md Outdated

@martinkilbinger martinkilbinger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

Comment thread docs/wiki/module_docs/mccd_instructions.md
Comment thread example/test_mccd/test_classic_interpolation.ini
Comment thread example/test_mccd/test_complete_pipe.ini
Comment thread requirements.txt
Comment thread shapepipe/modules/MCCD_package/mccd_interpolation_script.py Outdated
Comment thread shapepipe/modules/MCCD_package/mccd_interpolation_script.py Outdated
Comment thread shapepipe/modules/MCCD_package/mccd_plot_utilities.py
Comment thread shapepipe/modules/MCCD_package/mccd_plot_utilities.py Outdated
Comment thread shapepipe/modules/MCCD_package/mccd_plot_utilities.py
Comment thread shapepipe/modules/mccd_preprocessing_runner.py Outdated
@sfarrens sfarrens added the enhancement New feature or request label Oct 27, 2020
@sfarrens sfarrens added this to the General Improvements milestone Oct 27, 2020
This was linked to issues Oct 27, 2020
Created new fork for Stile package with the fix needed for computing the rho stats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MCCD/RCA PSF validation scripts enhancements

4 participants