Repository navigation
feat(deps): support chardet v7 - #1110
Merged
Merged
Conversation
The Chardet <6 constraint cannot resolve with a requirement for Chardet 7. Allow Chardet 7 while retaining Chardet 5 support. Exclude Chardet 6: 6.0.0.post1 returns no encoding for the existing CP1252 requirements fixture, so stdin decoding falls back to UTF-8 and fails. The existing tests for requirements on stdin pass with Chardet 7.0.0 and 7.6.0 on Python 3.12, including that fixture. The native Poetry lock continues to resolve Chardet 5.2.0 for the project's Python 3.9+ range. Codex for Tamir. Signed-off-by: Tamir Duberstein <tamird@gmail.com>
Up to standards ✅🟢 Issues
|
Documentation build overview
|
jkowalleck
requested changes
Sep 29, 2026
chardet v7
Closed
1 task done
Member
|
the version of poetry we use to build the package seams to be bugged regarding version constriants here. |
Author
|
I can prepare a migration to uv, if you like? |
jkowalleck
force-pushed
the
tamird/chardet-compat
branch
2 times, most recently
from
September 29, 2026 15:03
f3dede1 to
c6229c7
Compare
chardet v7chardet v7
jkowalleck
approved these changes
Sep 29, 2026
Member
thanks. not needed at the moment. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Installing
cyclonedx-bomalongside a Chardet 7 requirement currently fails dependency resolution because this project caps Chardet below 6. Allow Chardet 7 while retaining Chardet 5, and exclude Chardet 6: 6.0.0.post1 returns no encoding for the existing CP1252 requirements fixture, sorequirements -falls back to UTF-8 and fails.On Python 3.12, the existing tests for requirements on stdin passed with Chardet 7.0.0 and 7.6.0, including the CP1252 fixture. The final native Poetry lock continues to choose Chardet 5.2.0 for the project's full Python 3.9+ range; the 7.x behavior was qualified separately with the same configured test command.
Tox's isolated wheel setup stopped before tests because poetry-core 2.5.0 emitted an invalid requirement from the unchanged
cyclonedx-python-libunion. The results above came from running Tox's configured unittest command directly in the Poetry project environment. That environment's Requests 2.32.5 also emittedRequestsDependencyWarningwhen Chardet 7 was selected.Resolves or fixes issue: #1109
AI Tool Disclosure
Affirmation
Codex for Tamir.