Skip to content

Rename RUM operation strong link path parameter from feature_id to journey_id #4087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dd-octo-sts wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rename RUM operation strong link path parameter from feature_id to journey_id #4087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .generator/schemas/v2/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201588,7 +201588,7 @@ paths:
x-unstable: |-
**Note**: This endpoint is in Preview and is subject to change.
If you have any feedback, contact [Datadog support](https://docs.datadoghq.com/help/).
/api/v2/rum/operations/strong_links/{rum_operation_id}/{feature_id}:
/api/v2/rum/operations/strong_links/{rum_operation_id}/{journey_id}:
delete:
description: Delete the strong link between a RUM operation and a feature.
operationId: DeleteRUMOperationStrongLink
Expand All @@ -201599,9 +201599,9 @@ paths:
required: true
schema:
type: string
- description: The unique identifier of the feature.
- description: The unique identifier of the journey.
in: path
name: feature_id
name: journey_id
required: true
schema:
type: string
Expand Down Expand Up @@ -201632,9 +201632,9 @@ paths:
required: true
schema:
type: string
- description: The unique identifier of the feature.
- description: The unique identifier of the journey.
in: path
name: feature_id
name: journey_id
required: true
schema:
type: string
Expand Down
2 changes: 1 addition & 1 deletion examples/v2/rum-operations/DeleteRUMOperationStrongLink.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@
api_instance = RUMOperationsApi(api_client)
api_instance.delete_rum_operation_strong_link(
rum_operation_id="rum_operation_id",
feature_id="feature_id",
journey_id="journey_id",
)
2 changes: 1 addition & 1 deletion examples/v2/rum-operations/UpdateRUMOperationStrongLink.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
with ApiClient(configuration) as api_client:
api_instance = RUMOperationsApi(api_client)
response = api_instance.update_rum_operation_strong_link(
rum_operation_id="rum_operation_id", feature_id="feature_id", body=body
rum_operation_id="rum_operation_id", journey_id="journey_id", body=body
)

print(response)
28 changes: 14 additions & 14 deletions src/datadog_api_client/v2/api/rum_operations_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def __init__(self, api_client=None):
settings={
"response_type": None,
"auth": ["apiKeyAuth", "appKeyAuth", "AuthZ"],
"endpoint_path": "/api/v2/rum/operations/strong_links/{rum_operation_id}/{feature_id}",
"endpoint_path": "/api/v2/rum/operations/strong_links/{rum_operation_id}/{journey_id}",
"operation_id": "delete_rum_operation_strong_link",
"http_method": "DELETE",
"version": "v2",
Expand All @@ -114,10 +114,10 @@ def __init__(self, api_client=None):
"attribute": "rum_operation_id",
"location": "path",
},
"feature_id": {
"journey_id": {
"required": True,
"openapi_types": (str,),
"attribute": "feature_id",
"attribute": "journey_id",
"location": "path",
},
},
Expand Down Expand Up @@ -306,7 +306,7 @@ def __init__(self, api_client=None):
settings={
"response_type": (RUMOperationStrongLinkResponse,),
"auth": ["apiKeyAuth", "appKeyAuth", "AuthZ"],
"endpoint_path": "/api/v2/rum/operations/strong_links/{rum_operation_id}/{feature_id}",
"endpoint_path": "/api/v2/rum/operations/strong_links/{rum_operation_id}/{journey_id}",
"operation_id": "update_rum_operation_strong_link",
"http_method": "PUT",
"version": "v2",
Expand All @@ -318,10 +318,10 @@ def __init__(self, api_client=None):
"attribute": "rum_operation_id",
"location": "path",
},
"feature_id": {
"journey_id": {
"required": True,
"openapi_types": (str,),
"attribute": "feature_id",
"attribute": "journey_id",
"location": "path",
},
"body": {
Expand Down Expand Up @@ -388,22 +388,22 @@ def delete_rum_operation(
def delete_rum_operation_strong_link(
self,
rum_operation_id: str,
feature_id: str,
journey_id: str,
) -> None:
"""Delete a RUM operation strong link.

Delete the strong link between a RUM operation and a feature.

:param rum_operation_id: The unique identifier of the RUM operation.
:type rum_operation_id: str
:param feature_id: The unique identifier of the feature.
:type feature_id: str
:param journey_id: The unique identifier of the journey.
:type journey_id: str
:rtype: None
"""
kwargs: Dict[str, Any] = {}
kwargs["rum_operation_id"] = rum_operation_id

kwargs["feature_id"] = feature_id
kwargs["journey_id"] = journey_id

return self._delete_rum_operation_strong_link_endpoint.call_with_http_info(**kwargs)

Expand Down Expand Up @@ -560,7 +560,7 @@ def update_rum_operation(
def update_rum_operation_strong_link(
self,
rum_operation_id: str,
feature_id: str,
journey_id: str,
body: RUMOperationStrongLinkUpdateRequest,
) -> RUMOperationStrongLinkResponse:
"""Update a RUM operation strong link.
Expand All @@ -569,15 +569,15 @@ def update_rum_operation_strong_link(

:param rum_operation_id: The unique identifier of the RUM operation.
:type rum_operation_id: str
:param feature_id: The unique identifier of the feature.
:type feature_id: str
:param journey_id: The unique identifier of the journey.
:type journey_id: str
:type body: RUMOperationStrongLinkUpdateRequest
:rtype: RUMOperationStrongLinkResponse
"""
kwargs: Dict[str, Any] = {}
kwargs["rum_operation_id"] = rum_operation_id

kwargs["feature_id"] = feature_id
kwargs["journey_id"] = journey_id

kwargs["body"] = body

Expand Down
10 changes: 5 additions & 5 deletions tests/v2/features/rum_operations.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ Feature: RUM Operations
Given operation "DeleteRUMOperationStrongLink" enabled
And new "DeleteRUMOperationStrongLink" request
And request contains "rum_operation_id" parameter from "REPLACE.ME"
And request contains "feature_id" parameter from "REPLACE.ME"
And request contains "journey_id" parameter from "REPLACE.ME"
When the request is sent
Then the response status is 204 No Content

Expand All @@ -97,7 +97,7 @@ Feature: RUM Operations
Given operation "DeleteRUMOperationStrongLink" enabled
And new "DeleteRUMOperationStrongLink" request
And request contains "rum_operation_id" parameter from "REPLACE.ME"
And request contains "feature_id" parameter from "REPLACE.ME"
And request contains "journey_id" parameter from "REPLACE.ME"
When the request is sent
Then the response status is 404 Not Found

Expand Down Expand Up @@ -208,7 +208,7 @@ Feature: RUM Operations
Given operation "UpdateRUMOperationStrongLink" enabled
And new "UpdateRUMOperationStrongLink" request
And request contains "rum_operation_id" parameter from "REPLACE.ME"
And request contains "feature_id" parameter from "REPLACE.ME"
And request contains "journey_id" parameter from "REPLACE.ME"
And body with value {"data": {"attributes": {"status": "CONFIRMED"}, "type": "strong_links"}}
When the request is sent
Then the response status is 400 Bad Request
Expand All @@ -218,7 +218,7 @@ Feature: RUM Operations
Given operation "UpdateRUMOperationStrongLink" enabled
And new "UpdateRUMOperationStrongLink" request
And request contains "rum_operation_id" parameter from "REPLACE.ME"
And request contains "feature_id" parameter from "REPLACE.ME"
And request contains "journey_id" parameter from "REPLACE.ME"
And body with value {"data": {"attributes": {"status": "CONFIRMED"}, "type": "strong_links"}}
When the request is sent
Then the response status is 404 Not Found
Expand All @@ -228,7 +228,7 @@ Feature: RUM Operations
Given operation "UpdateRUMOperationStrongLink" enabled
And new "UpdateRUMOperationStrongLink" request
And request contains "rum_operation_id" parameter from "REPLACE.ME"
And request contains "feature_id" parameter from "REPLACE.ME"
And request contains "journey_id" parameter from "REPLACE.ME"
And body with value {"data": {"attributes": {"status": "CONFIRMED"}, "type": "strong_links"}}
When the request is sent
Then the response status is 200 OK
Loading